fix(Buffer): prevent memory leak when Custom GC is used #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a piece of custom logic that has been added a while back to ensure that Buffers can be sent across threads, and be dropped properly. This involves a custom GC that runs on NodeJS's current thread (per my understanding). The logic to drop the buffer on that custom GC differed from the one in the Drop impl. This meant that everytime Node sent a buffer back to a napi-rs function, the reference wouldn't be cleaned up properly, and it would leak (96 bytes per Reference on an ARM MacOS machine). This commit updates the logic in the custom GC so that it matches the one in the Drop impl. This worked locally, and fixed any occurence of the leak I could find.
lbarthon
force-pushed
the
lbarthon/buffer-customgc-leak
branch
from
9a2845d
to
a806675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a piece of custom logic that has been added a while back to ensure that Buffers can be sent across threads, and be dropped properly. This involves a custom GC that runs on NodeJS's current thread (per my understanding). The logic to drop the buffer on that custom GC differed from the one in the Drop impl. This meant that everytime Node sent a buffer back to a napi-rs function, the reference wouldn't be cleaned up properly, and it would leak (96 bytes per Reference on an ARM MacOS machine).
This commit updates the logic in the custom GC so that it matches the one in the Drop impl. This worked locally, and fixed any occurence of the leak I could find.