fix(napi): no panic when caller stops listening #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is similar to the one in napi-rs@5b5f616. In both the then_callback & catch_callback, expect was being called in case the send failed. This means that if we call a function that returns a promise and the received gets closed (the calling thread stopped at the wrong time), this will panic. In such scenarios, it is fine not to panic. If the receiver doesn't care about the output, we should just let it be.
Brooooooklyn
changed the title
|
Hey @Brooooooklyn - sorry for the pings - any idea when you'll be able to tag on top of that? |
Brooooooklyn
pushed a commit
that referenced
this pull request
Mar 26, 2024
This fix is similar to the one in 5b5f616. In both the then_callback & catch_callback, expect was being called in case the send failed. This means that if we call a function that returns a promise and the received gets closed (the calling thread stopped at the wrong time), this will panic. In such scenarios, it is fine not to panic. If the receiver doesn't care about the output, we should just let it be.
Brooooooklyn
pushed a commit
that referenced
this pull request
Mar 26, 2024
This fix is similar to the one in 5b5f616. In both the then_callback & catch_callback, expect was being called in case the send failed. This means that if we call a function that returns a promise and the received gets closed (the calling thread stopped at the wrong time), this will panic. In such scenarios, it is fine not to panic. If the receiver doesn't care about the output, we should just let it be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is similar to the one in 5b5f616.
In both the then_callback & catch_callback, expect was being called in case the send failed. This means that if we call a function that returns a promise and the received gets closed (the calling thread stopped at the wrong time), this will panic.
In such scenarios, it is fine not to panic. If the receiver doesn't care about the output, we should just let it be.