Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(napi): support chrono datetime with timezones #2074

Merged
merged 2 commits into from
Apr 30, 2024
Merged

feat(napi): support chrono datetime with timezones #2074

merged 2 commits into from
Apr 30, 2024

Conversation

naskya
Copy link
Contributor

@naskya naskya commented Apr 30, 2024

This pull request adds support for chrono::DateTime<Local> and chrono::DateTime<FixedOffset>.

All of the following types are converted to JavaScript Date with this implementation:

  • chrono::NaiveDateTime
  • chrono::DateTime<Utc>
  • chrono::DateTime<Local>
  • chrono::DateTime<FixedOffset>

Follow-up of:

Closes:

sup39 and others added 2 commits April 29, 2024 19:26
@sup39 @naskya
feat(napi): implement From/ToNapiValue for chrono::DateTime<Local> an…
6a9ae13 
…d chrono::DateTime<FixedOffset> (napi-rs#1902)
@naskya @sup39
chore(napi): update tests
27b64d9 
Co-authored-by: sup39 <dev@sup39.dev>
@Brooooooklyn Brooooooklyn merged commit 68b5f2c into napi-rs:main Apr 30, 2024
48 of 49 checks passed
@Brooooooklyn Brooooooklyn mentioned this pull request Apr 30, 2024
Closed
@naskya naskya deleted the feat/support-chrono-with-timezones branch May 1, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@naskya @Brooooooklyn @sup39