Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(napi): remove depracated get_js_function #2101

Merged

Conversation

Brooooooklyn
Copy link
Sponsor Member

@Brooooooklyn Brooooooklyn commented May 8, 2024

Copy link
Sponsor Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite Graphite

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: cd5fadc Previous: 1d130f1 Ratio
noop#napi-rs 85315898 ops/sec (±2.24%) 86504337 ops/sec (±0.27%) 1.01
noop#JavaScript 818513384 ops/sec (±0.1%) 818129838 ops/sec (±0.28%) 1.00
Plus number#napi-rs 21977789 ops/sec (±3.65%) 22059050 ops/sec (±0.15%) 1.00
Plus number#JavaScript 816904206 ops/sec (±0.11%) 817603987 ops/sec (±0.1%) 1.00
Create buffer#napi-rs 624444 ops/sec (±13.14%) 610007 ops/sec (±12.28%) 0.98
Create buffer#JavaScript 3139377 ops/sec (±2.8%) 3054288 ops/sec (±2.99%) 0.97
createArray#createArrayJson 52415 ops/sec (±3.9%) 51484 ops/sec (±1.03%) 0.98
createArray#create array for loop 9272 ops/sec (±0.79%) 10276 ops/sec (±0.37%) 1.11
createArray#create array with serde trait 9295 ops/sec (±0.78%) 10207 ops/sec (±0.52%) 1.10
getArrayFromJs#get array from json string 23307 ops/sec (±1.7%) 23930 ops/sec (±0.95%) 1.03
getArrayFromJs#get array from serde 11104 ops/sec (±2.09%) 12784 ops/sec (±0.48%) 1.15
getArrayFromJs#get array with for loop 9848 ops/sec (±3.54%) 15987 ops/sec (±0.19%) 1.62
Get Set property#Get Set from native#u32 548442 ops/sec (±7.91%) 582370 ops/sec (±12.03%) 1.06
Get Set property#Get Set from JavaScript#u32 485121 ops/sec (±9.91%) 543224 ops/sec (±2.32%) 1.12
Get Set property#Get Set from native#string 510571 ops/sec (±11.19%) 560739 ops/sec (±11.55%) 1.10
Get Set property#Get Set from JavaScript#string 487552 ops/sec (±1.89%) 514879 ops/sec (±2.35%) 1.06
Async task#spawn task 26331 ops/sec (±0.72%) 26575 ops/sec (±0.36%) 1.01
Async task#ThreadSafeFunction 8893 ops/sec (±0.69%) 8894 ops/sec (±0.72%) 1.00
Async task#Tokio future to Promise 34230 ops/sec (±1.55%) 34880 ops/sec (±1.63%) 1.02
Query#query * 100 3582 ops/sec (±0.63%) 3587 ops/sec (±0.39%) 1.00
Query#query * 1 26292 ops/sec (±1.48%) 26894 ops/sec (±1.61%) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

@Brooooooklyn Brooooooklyn enabled auto-merge (squash) May 9, 2024 07:13
@Brooooooklyn Brooooooklyn disabled auto-merge May 9, 2024 07:13
@Brooooooklyn Brooooooklyn merged commit 1e781a5 into main May 9, 2024
50 checks passed
@Brooooooklyn Brooooooklyn deleted the 05-08-chore_napi_remove_depracated_get_js_function branch May 9, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove get_js_function
1 participant