Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): prevent the wasm optimization crash the build #2107

Merged

Conversation

Brooooooklyn
Copy link
Sponsor Member

No description provided.

Copy link
Sponsor Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite Graphite

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: dd08126 Previous: b2239fd Ratio
noop#napi-rs 85652490 ops/sec (±1.38%) 86908407 ops/sec (±0.13%) 1.01
noop#JavaScript 820427685 ops/sec (±0.07%) 821379398 ops/sec (±0.16%) 1.00
Plus number#napi-rs 22716822 ops/sec (±0.24%) 22708610 ops/sec (±0.66%) 1.00
Plus number#JavaScript 816432746 ops/sec (±0.54%) 817970862 ops/sec (±0.12%) 1.00
Create buffer#napi-rs 634232 ops/sec (±12.29%) 621232 ops/sec (±14.01%) 0.98
Create buffer#JavaScript 4070291 ops/sec (±1.59%) 3061107 ops/sec (±2.66%) 0.75
createArray#createArrayJson 54298 ops/sec (±0.33%) 54030 ops/sec (±0.72%) 1.00
createArray#create array for loop 9704 ops/sec (±0.56%) 10382 ops/sec (±0.19%) 1.07
createArray#create array with serde trait 9745 ops/sec (±0.32%) 10206 ops/sec (±0.28%) 1.05
getArrayFromJs#get array from json string 22845 ops/sec (±0.12%) 23699 ops/sec (±0.37%) 1.04
getArrayFromJs#get array from serde 13064 ops/sec (±0.53%) 12629 ops/sec (±1.29%) 0.97
getArrayFromJs#get array with for loop 15910 ops/sec (±0.47%) 16277 ops/sec (±0.43%) 1.02
Get Set property#Get Set from native#u32 559215 ops/sec (±11.88%) 566159 ops/sec (±13.29%) 1.01
Get Set property#Get Set from JavaScript#u32 546930 ops/sec (±2.36%) 552751 ops/sec (±2.46%) 1.01
Get Set property#Get Set from native#string 550741 ops/sec (±11.14%) 569216 ops/sec (±11.96%) 1.03
Get Set property#Get Set from JavaScript#string 510978 ops/sec (±2.1%) 521261 ops/sec (±1.97%) 1.02
Async task#spawn task 26662 ops/sec (±0.33%) 26479 ops/sec (±0.9%) 0.99
Async task#ThreadSafeFunction 8946 ops/sec (±1%) 9074 ops/sec (±0.87%) 1.01
Async task#Tokio future to Promise 34922 ops/sec (±1.31%) 35108 ops/sec (±0.78%) 1.01
Query#query * 100 3557 ops/sec (±0.4%) 3604 ops/sec (±1.4%) 1.01
Query#query * 1 26356 ops/sec (±1.45%) 27472 ops/sec (±0.65%) 1.04

This comment was automatically generated by workflow using github-action-benchmark.

@Brooooooklyn Brooooooklyn merged commit c9c3c0e into main May 12, 2024
50 checks passed
@Brooooooklyn Brooooooklyn deleted the 05-12-fix_cli_prevent_the_wasm_optimization_crash_the_build branch May 12, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant