Skip to content

Conversation

@richerfu
Copy link
Contributor

No description provided.

@Brooooooklyn
Copy link
Member

You should make the typegen correct for the calledhandled = true tsfn

@richerfu
Copy link
Contributor Author

I think we don't need to add some logic for ThreadsafeFunctionBuilder with calleehandled = true.
It just is used to generate ThreadsafeFunction which is support typegen, right?

Brooooooklyn
Brooooooklyn previously approved these changes May 17, 2024
@richerfu richerfu force-pushed the feat-calleehandle branch from 1d34e9a to 4734f6c Compare May 17, 2024 03:49
@richerfu
Copy link
Contributor Author

Resolve conflict

@Brooooooklyn Brooooooklyn merged commit c52d204 into napi-rs:main May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants