-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce #[napi]
procedural macro to automation development boilerplate
#696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6d7e98
to
139c002
Compare
7bde75a
to
703a319
Compare
Just want to say that this PR is awesome. This will dramatically lower the barrier to entry for JS devs just learning Rust while also removing boilerplate. +1000000000000 for this |
4d3fbb1
to
e85a387
Compare
@jaredpalmer It's truly happening and we almost get there. The things left are just cleaning up and covering cases. |
a36391e
to
3e91869
Compare
7c96d33
to
2d41036
Compare
99dbec6
to
90dfa7a
Compare
#[napi]
procedural macro to automation development boilerplate#[napi]
procedural macro to automation development boilerplate
|
Brooooooklyn
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion: #684. This PR would include all the things listed below
#[napi]
function
js <=> rust value mapping
auto-exports
#[napi(strict)]
, would be slow)What would come with releases later on:
Greatly thank wasm_bindgen for where the idea originally coming from when exploring it's codebase, and node_bindgen for the idea of implicit exports registering at runtime.