Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bindings script for latest rust #1

Merged
merged 1 commit into from Nov 7, 2019
Merged

Conversation

pitaj
Copy link
Contributor

@pitaj pitaj commented May 8, 2019

  • Use rustup component (cargo fmt)
  • Don't automatically install stuff on user's computer
  • Detect node headers path
  • Update bindgen options
  • Test after bindings are generated
  • Add some rudimentary instructions to readme

- Use rustup component (cargo fmt)
- Don't automatically install stuff on user's computer
- Detect node headers path
- Update bindgen options
- Test after bindings are generated
- Add some rudimentary instructions to readme
Copy link
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry for taking so long to respond. Thanks a lot for the contribution, this looks great!

@aqrln aqrln merged commit 7c56807 into napi-rs:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants