Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deno lint [skip ci] #61

Merged
merged 4 commits into from
Aug 18, 2020
Merged

feat: deno lint [skip ci] #61

merged 4 commits into from
Aug 18, 2020

Conversation

Brooooooklyn
Copy link
Sponsor Member

@Brooooooklyn Brooooooklyn commented Jun 15, 2020

  • Implement napi_create_external in napi-rs
  • Figure out whether the benchmark is fairly enough

@Brooooooklyn
Copy link
Sponsor Member Author

First benchmark:

@node-rs/deno-lint x 287 ops/sec ±2.45% (80 runs sampled)
eslint x 56.22 ops/sec ±10.73% (60 runs sampled)
Lint benchmark bench suite: Fastest is @node-rs/deno-lint
[1]    75582 segmentation fault  node packages/deno-lint/benchmark/lint.js

Got segmentation fault because we need napi_create_external instead of napi_wrap

@Brooooooklyn
Copy link
Sponsor Member Author

Segment fault cased by double free input source code Buffer

@node-rs/deno-lint x 282 ops/sec ±2.39% (79 runs sampled)
eslint x 56.84 ops/sec ±8.65% (65 runs sampled)
Lint benchmark bench suite: Fastest is @node-rs/deno-lint

@Brooooooklyn Brooooooklyn force-pushed the deno-lint branch 2 times, most recently from aac0699 to e520104 Compare June 19, 2020 07:11
@Brooooooklyn Brooooooklyn force-pushed the deno-lint branch 3 times, most recently from 1b984f8 to 3514af5 Compare July 15, 2020 04:31
@Brooooooklyn
Copy link
Sponsor Member Author

After upgrade to deno_lint@0.1.16

@node-rs/deno-lint x 2,172 ops/sec ±0.91% (91 runs sampled)
eslint x 56.42 ops/sec ±8.18% (59 runs sampled)
Lint benchmark bench suite: Fastest is @node-rs/deno-lint

@Brooooooklyn Brooooooklyn force-pushed the deno-lint branch 2 times, most recently from bfbec20 to 83baa21 Compare August 17, 2020 16:29
@Brooooooklyn Brooooooklyn changed the title [wip]feat: deno lint [skip ci] feat: deno lint [skip ci] Aug 18, 2020
@Brooooooklyn Brooooooklyn marked this pull request as ready for review August 18, 2020 16:19
@Brooooooklyn Brooooooklyn merged commit 7cd17ff into master Aug 18, 2020
@Brooooooklyn Brooooooklyn deleted the deno-lint branch August 18, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant