Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰css issue with images and empty text #1001

Closed
4 tasks done
biplavmz opened this issue Jul 27, 2023 · 5 comments 路 Fixed by #1005
Closed
4 tasks done

馃悰css issue with images and empty text #1001

biplavmz opened this issue Jul 27, 2023 · 5 comments 路 Fixed by #1005
Assignees
@biplavmz
Labels
bug codepeak level1

Comments

@biplavmz
Copy link
Contributor

biplavmz commented Jul 27, 2023 •
edited
Loading

Description

馃悰css issue with images and empty text

I'm a GSSoC'23 contributor please assign me this issue under gssoc label and level.

Steps to reproduce

go to website and check the post card

Screenshots

before :-
image

After :-
image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional information

No response

Record

  • I agree to follow this project's Code of Conduct
  • I have checked the existing issues
  • I'm a GSSoC'23 contributor
  • I want to work on this issue
@biplavmz biplavmz added the bug label Jul 27, 2023
@github-actions
Copy link

Hello biplavmz!
Thank you for raising this issue! 馃槉 Your contribution is valuable to us! 馃槉

Please make sure to follow our Contributing Guidelines. 馃挭馃徎

Our reviewers shall carefully assess the issue and reach out to you soon! 馃槆
We appreciate your patience!

@narayan954
Copy link
Owner

you mean their fitness? yes you can definitely work on this and please ensure, images don't get cropped out

@narayan954 narayan954 assigned narayan954 and biplavmz and unassigned narayan954 Jul 27, 2023
@narayan954
Copy link
Owner

Description

bugcss issue with images and empty text

I'm a GSSoC'23 contributor please assign me this issue under gssoc label and level.

Steps to reproduce

go to website and check the post card

Screenshots

before :- image

After :- image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional information

No response

Record

  • I agree to follow this project's Code of Conduct
  • I have checked the existing issues
  • I'm a GSSoC'23 contributor
  • I want to work on this issue

I didn't understand the images you provided, you're just comparing two different images

@biplavmz
Copy link
Contributor Author

bro @narayan954 if you see when there is no images only text on gride view images alignment get uneven so i have fix that issue i will raise mr for that and i will also ensure no to crop the images.

biplavmz added a commit to biplavmz/dummygram that referenced this issue Jul 28, 2023
@biplavmz
css card alignment issue narayan954#1001
2be120e
@biplavmz biplavmz mentioned this issue Jul 28, 2023
Merged
@narayan954
Copy link
Owner

bro @narayan954 if you see when there is no images only text on gride view images alignment get uneven so i have fix that issue i will raise mr for that and i will also ensure no to crop the images.

Thanks bro, you can go ahead!

@narayan954 narayan954 linked a pull request Aug 1, 2023 that will close this issue
css card alignment issue #1001 #1005
Merged
narayan954 added a commit that referenced this issue Aug 1, 2023
@biplavmz @narayan954
css card alignment issue #1001 (#1005)
d2a3820 
* css card alignment issue #1001

* bug-issue-1001 alignment issue

* style: format

---------

Co-authored-by: Narayan soni <narayansoni854@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@biplavmz biplavmz

Labels
bug codepeak level1
Projects
Dummygram
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

css card alignment issue #1001 biplavmz/dummygram
2 participants
@biplavmz @narayan954