Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix white space on mobile view and z axis of theme switcher #146

Closed
kshitij01042002 opened this issue Dec 26, 2022 · 12 comments
Closed

fix white space on mobile view and z axis of theme switcher #146

kshitij01042002 opened this issue Dec 26, 2022 · 12 comments
Assignees
@TheXro
Labels
bug easy

Comments

@kshitij01042002
Copy link
Contributor

kshitij01042002 commented Dec 26, 2022 •
edited by narayan954
Loading

Description

fixing white space on mobile view and z axis of theme switcher

Steps to reproduce

View in mobile view

Screenshots

image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional information

No response
@kshitij01042002 kshitij01042002 mentioned this issue Dec 27, 2022
Merged
@anshuman-com
Copy link

I can fix this issue can you please assign it to me under iwoc

@anshuman-com
Copy link

this fix is unnecessary its already working all right in mobile view

@narayan954
Copy link
Owner

this fix is unnecessary its already working all right in mobile view

Yeah actually, the fix was done, but there're two issues , z axis of dark mode button and extra white space on right in mobile view, when you move to the right side.
image for your reference, we can update this issue with this problem or create a new issue
extra blank space

@anshuman-com
Copy link

we can create a new issue , can you please tell where you have written code of and themeswitch button , three dot button also i didn't get your second issue as their
Screenshot (8)
is equal space on left and right in mobile view.

@anshuman-com
Copy link

there is one more issue themeswitch button gets hidden under an image.

issues.mp4

@anshuman-com
Copy link

theme switch button doesn't work when it is on image or 3 dot button

issue1.mp4

@narayan954
Copy link
Owner

narayan954 commented Feb 1, 2023 •
edited
Loading

we can create a new issue , can you please tell where you have written code of and themeswitch button , three dot button also i didn't get your second issue as their Screenshot (8) is equal space on left and right in mobile view.

sure, we can. Try moving right by clicking and holding the screen.

WhatsApp.Video.2023-02-01.at.22.34.45.mp4

@narayan954
Copy link
Owner

narayan954 commented Feb 1, 2023 •
edited
Loading

there is one more issue themeswitch button gets hidden under an image.

issues.mp4

that's what i meant by z axis

@narayan954
Copy link
Owner

theme switch button doesn't work when it is on image or 3 dot button

issue1.mp4

well yes, because it's under that element

@narayan954 narayan954 changed the title Responsiveness fix white space on mobile view and z axis of theme switcher Feb 1, 2023
Repository owner deleted a comment from kshitij01042002 Feb 1, 2023
Repository owner deleted a comment from kshitij01042002 Feb 1, 2023
Repository owner deleted a comment from kshitij01042002 Feb 1, 2023
@narayan954
Copy link
Owner

I have updated this issue only to address the problem

@TheXro
Copy link
Contributor

TheXro commented Feb 13, 2023

@narayan954 i want to work on this can you please assign it to me under iwoc

@narayan954
Copy link
Owner

@narayan954 i want to work on this can you please assign it to me under iwoc

sure go ahead! :)

narayan954 added a commit that referenced this issue Feb 13, 2023
@narayan954
Merge pull request #156 from TheXro/TheXro
f3214fb 
fixed: fix white space on mobile view and z axis of theme switcher #146
@narayan954 narayan954 removed the jwoc label Feb 13, 2023
narayan954 added a commit that referenced this issue Feb 14, 2023
@narayan954
Squashed commit of the following:
d660d7a 
commit 0517aaf
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Wed Feb 15 00:59:45 2023 +0530

    Update package-lock.json

commit 4b57c30
Merge: ee7a41a bbdc4cd
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Wed Feb 15 00:55:56 2023 +0530

    Merge branch 'master' of https://github.com/narayan954/dummygram

commit ee7a41a
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Wed Feb 15 00:55:30 2023 +0530

    update dependencies using ncu

commit bbdc4cd
Merge: 93a7f0b 29f1472
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Wed Feb 15 00:50:23 2023 +0530

    Merge pull request #162 from narayan954/deepsource-transform-749baf1a

commit 29f1472
Author: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Date:   Tue Feb 14 19:18:36 2023 +0000

    Format code with prettier

    This commit fixes the style issues introduced in 93a7f0b according to the output
    from prettier.

    Details: https://deepsource.io/gh/narayan954/dummygram/transform/3d05dcf5-af9b-44e2-bdc0-6f568250e0db/

commit 93a7f0b
Merge: 0711181 a531d72
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Wed Feb 15 00:48:24 2023 +0530

    Merge pull request #159 from TheXro/darkmode

    fixed: Post background changes color on switching to dark mode #118

commit 0711181
Merge: 247a1da 9e1abd2
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Wed Feb 15 00:31:53 2023 +0530

    Merge pull request #161 from A91y/master

    Updated CONTRIBUTING.md and README.md

commit 9e1abd2
Author: A91y <ayush.agr254@gmail.com>
Date:   Wed Feb 15 00:22:15 2023 +0530

    Updated CONTRIBUTING.md and README.md

commit a531d72
Author: TheXro <ravyyadav97@gmail.com>
Date:   Tue Feb 14 21:24:01 2023 +0530

    fixed issue #118

commit 247a1da
Merge: f3214fb fcd0865
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Tue Feb 14 01:32:25 2023 +0530

    Merge pull request #157 from narayan954/deepsource-transform-015baf48

commit fcd0865
Author: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Date:   Mon Feb 13 20:00:26 2023 +0000

    Format code with prettier

    This commit fixes the style issues introduced in f3214fb according to the output
    from prettier.

    Details: https://deepsource.io/gh/narayan954/dummygram/transform/014a0045-5ff3-455b-a465-ae9e4d965d28/

commit f3214fb
Merge: ab136eb 533cdbe
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Tue Feb 14 01:30:13 2023 +0530

    Merge pull request #156 from TheXro/TheXro

    fixed: fix white space on mobile view and z axis of theme switcher #146

commit 533cdbe
Author: TheXro <ravyyadav97@gmail.com>
Date:   Mon Feb 13 19:08:40 2023 +0530

    fixed issue #146

commit ab136eb
Merge: b4939e4 5485504
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Sun Feb 5 18:13:01 2023 +0530

    Merge pull request #139 from narayan954/deepsource-fix-9bbfc17a

    Remove `true` from boolean attribute

commit 5485504
Merge: 9331c9b 63dd7f1
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Sat Dec 24 23:07:28 2022 +0530

    Merge branch 'master' into deepsource-fix-9bbfc17a

commit 9331c9b
Author: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Date:   Tue Dec 20 16:43:32 2022 +0000

    Remove `true` from boolean attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheXro TheXro

Labels
bug easy
Projects
Dummygram
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anshuman-com @narayan954 @TheXro @kshitij01042002