Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] <Zoom in profile picture> #497

Closed
SubhamB2003 opened this issue Jun 18, 2023 · 8 comments · Fixed by #500
Closed

[FEATURE] <Zoom in profile picture> #497

SubhamB2003 opened this issue Jun 18, 2023 · 8 comments · Fixed by #500

Comments

@SubhamB2003
Copy link
Contributor

Description

Hey, I want to add the zoom-in profile picture feature. If I click the profile picture then it is zoomed in.

Like this
image

Please assign it to me under GSSOC'23.

Screenshots

No response

Additional information

No response

@narayan954
Copy link
Owner

narayan954 commented Jun 18, 2023

Hi @SubhamB2003 where do you want to add this feature, we can view profile picture in posts as well as profile.
Though I am expecting the profile.
Why? because currently if we click on the profile picture on posts , it redirects to their profile.
I think it'd be better when user is in profile page. Anyone, should be able to zoom in on the profile picture. And for the profile owner we can add option to modify the picture as well. Last one is optional and it'd upgrade this issue to level 2(modifying feature is present already, just need to move it there.

What're you opinions and suggestions on this?

@SubhamB2003
Copy link
Contributor Author

Hi @SubhamB2003 where do you want to add this feature, we can view profile picture in posts as well as profile. Though I am expecting the profile. Why? because currently if we click on the profile picture on posts , it redirects to their profile. I think it'd be better when user is in profile page. Anyone, should be able to zoom in on the profile picture. And for the profile owner we can add option to modify the picture as well. Last one is optional and it'd upgrade this issue to level 2(modifying feature is present already, just need to move it there.

What're you opinions and suggestions on this?

Yeah, I add this feature to only the profile page. After clicking the profile picture it zooms in so the user can see a better view of the profile picture.

@narayan954
Copy link
Owner

clicking

cool go ahead!

@SubhamB2003
Copy link
Contributor Author

Reference in new

Hey, can you elaborate more on how can we modify it you saying this "And for the profile owner we can add an option to modify the picture as well"

@narayan954
Copy link
Owner

Reference in new

Hey, can you elaborate more on how can we modify it you saying this "And for the profile owner we can add an option to modify the picture as well"

there's already an option for profile owners to modify their profile picture by uploading another one. if we allow users to zoom on in the picture, we can add a update profile picture option in that popup/modal. Implementation can be copied almost

@SubhamB2003
Copy link
Contributor Author

Reference in new

Hey, can you elaborate more on how can we modify it you saying this "And for the profile owner we can add an option to modify the picture as well"

there's already an option for profile owners to modify their profile picture by uploading another one. if we allow users to zoom on in the picture, we can add a update profile picture option in that popup/modal. Implementation can be copied almost

Yeah, okk

@SubhamB2003
Copy link
Contributor Author

SubhamB2003 commented Jun 19, 2023

Reference in new

Hey, can you elaborate more on how can we modify it you saying this "And for the profile owner we can add an option to modify the picture as well"

there's already an option for profile owners to modify their profile picture by uploading another one. if we allow users to zoom on in the picture, we can add a update profile picture option in that popup/modal. Implementation can be copied almost

Hey, in update profile picture option after I choose the image the new image is not visible if I click save then after some time it is visible.

You can see here

profile.mp4

I want to add a feature where after choose the new image it is visible instantly. Can I also add this feature?

It should be like this

profile2.mp4

@narayan954
Copy link
Owner

Reference in new

Hey, can you elaborate more on how can we modify it you saying this "And for the profile owner we can add an option to modify the picture as well"

there's already an option for profile owners to modify their profile picture by uploading another one. if we allow users to zoom on in the picture, we can add a update profile picture option in that popup/modal. Implementation can be copied almost

Hey, in update profile picture option after I choose the image the new image is not visible if I click save then after some time it is visible.

You can see here

profile.mp4

I want to add a feature where after choose the new image it is visible instantly. Can I also add this feature?

It should be like this

profile2.mp4

yeah sure, it'd be great!!

@narayan954 narayan954 linked a pull request Jun 20, 2023 that will close this issue
@narayan954 narayan954 added level2 and removed level1 labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants