Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favourite route not showing liked posts #788

Closed
2 of 4 tasks
fiskryeziu opened this issue Jul 13, 2023 · 3 comments · Fixed by #801
Closed
2 of 4 tasks

Favourite route not showing liked posts #788

fiskryeziu opened this issue Jul 13, 2023 · 3 comments · Fixed by #801
Assignees
@fiskryeziu
Labels
bug

Comments

@fiskryeziu
Copy link
Contributor

Description

favourite route not displaying any liked posts.

Steps to reproduce

1.Go to /dummygram/favourites
2.See "You have nothing in favourites"

Screenshots

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional information

No response

Record

  • I agree to follow this project's Code of Conduct
  • I have checked the existing issues
  • I'm a GSSoC'23 contributor
  • I want to work on this issue
@fiskryeziu fiskryeziu added the bug label Jul 13, 2023
@fiskryeziu
Copy link
Contributor Author

Looks like the useEffect needs some improvements to fetch the liked posts of the user.

@narayan954
Copy link
Owner

narayan954 commented Jul 13, 2023 •
edited
Loading

Description

favourite route not displaying any liked posts.

Steps to reproduce

1.Go to /dummygram/favourites 2.See "You have nothing in favourites"

Screenshots

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional information

No response

Record

  • I agree to follow this project's Code of Conduct
  • I have checked the existing issues
  • I'm a GSSoC'23 contributor
  • I want to work on this issue

Yes you're right!,
Thanks for raising the issue!
In fact we're unable to get past the loader!

@narayan954
Copy link
Owner

Looks like the useEffect needs some improvements to fetch the liked posts of the user.

yes, you're right, it's not implemented correctly!

@fiskryeziu fiskryeziu mentioned this issue Jul 14, 2023
Merged
@narayan954 narayan954 linked a pull request Jul 14, 2023 that will close this issue
Favorite page fetch liked posts FIX #801
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fiskryeziu fiskryeziu

Labels
bug
Projects
Dummygram
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Favorite page fetch liked posts FIX
2 participants
@fiskryeziu @narayan954