-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Login page changes made #1004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you shruuti321! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shruuti321 can you please have a look at the alignment,some of it is getting disturbed.
changed version:
original version:
@narayan954 I am encountering this error while pushing |
as you read in the error hint, you need to pull first before pushing :) ... so try git pull command first then you can git push.... It's also written in the terminal as hint |
|
you're updating wrong branch perhaps, you're working on other branch... try |
it's because, I've pushed a change in your branch and your current local is behind the remote. You need to sync with your remote first :) |
So sorry for the inconvinience but I have even pulled and merged but still it is showing the same error |
it's alright, try each of these command I am telling below:
As a final resort, do |
If none of those work, let me know, I'll revert the commits I made, and then you'll be able to work normally :) Ps: But no, you should know how to fix this error, contact in discord if the issue persists |
But your changes are lost, perhaps you deleted the changes? |
I have made my final commits. Hope this time the changes are being reflected |
awesome, they look great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
thanks for your contribution! and do mention your issue, so I can add relevant labels |
Closing #984 |
And thankyou so much for providing the guidance and help on the spot :) |
Label please? |
right I forgot, sorry |
I have changed the login page background colour in both light and dark modes and also provided for margin form top.
![image](https://private-user-images.githubusercontent.com/114770273/256606903-f4653a66-d961-4f88-b2a3-65a77cf9a691.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2NDg0OTAsIm5iZiI6MTcxOTY0ODE5MCwicGF0aCI6Ii8xMTQ3NzAyNzMvMjU2NjA2OTAzLWY0NjUzYTY2LWQ5NjEtNGY4OC1iMmEzLTY1YTc3Y2Y5YTY5MS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyOVQwODAzMTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hYjlmYjUzNTViNmI5MjExMDcyMGI3ZjY3NGRiZGM5OTNiODRjZGJmZDZiYTUwZjMyNDRmODE3NDQxMDFmNDFlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.NgLziKCP6u0v9LgXLk3-D1cxARRwL23H9pFttFsh-Qo)
![image](https://private-user-images.githubusercontent.com/114770273/256606966-65636e87-136f-47ac-95c5-40df5c6eaa3b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2NDg0OTAsIm5iZiI6MTcxOTY0ODE5MCwicGF0aCI6Ii8xMTQ3NzAyNzMvMjU2NjA2OTY2LTY1NjM2ZTg3LTEzNmYtNDdhYy05NWM1LTQwZGY1YzZlYWEzYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyOVQwODAzMTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01MDZlNzA3ZjQyYjhiMmFiOTM3MTYxNjg4MWM0MDdhMzBiZDc1NGNkMTBhNDc3OGRkNmYyZDI3OTNiMDIyNzc0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.RdPGNLz92rZNxc48HNLTPn5yF0pLRi2_GGbh4VSLnu4)