Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix 929 #1006

Merged
merged 22 commits into from
Aug 3, 2023
Merged

Bug fix 929 #1006

merged 22 commits into from
Aug 3, 2023

Conversation

biplavmz
Copy link
Contributor

@biplavmz biplavmz commented Jul 28, 2023 •
edited by narayan954
Loading

bug fix #929 and fix #1002
image

github-actions[bot]
github-actions bot reviewed Jul 28, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you biplavmz! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

narayan954
narayan954 requested changes Jul 28, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @biplavmz it's adding to the ir-responsiveness in mobile view, please fix
image

@narayan954
Copy link
Owner

narayan954 commented Jul 28, 2023 •
edited
Loading

please check for all screens and send screenshots

@biplavmz
Copy link
Contributor Author

Hii @narayan954 is it ok
image

@biplavmz
Copy link
Contributor Author

Hii @narayan954 I have push the changes pls check and merge

narayan954
narayan954 requested changes Jul 31, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refactor the css you added

src/components/ProfileDialogBox/index.css Show resolved Hide resolved
src/components/ProfileDialogBox/index.css Outdated Show resolved Hide resolved
@biplavmz
Copy link
Contributor Author

biplavmz commented Aug 1, 2023

Hii @narayan954 I have fix the issue and refactor the css can you please check and merge my pr

narayan954
narayan954 requested changes Aug 1, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @biplavmz , the issue persists,
image
Can you please check this

@biplavmz
Copy link
Contributor Author

biplavmz commented Aug 1, 2023

Hii @narayan954 i have fix the issue pls check

image

@narayan954
Copy link
Owner

Hii @narayan954 i have fix the issue pls check

image

right, checking!

narayan954
narayan954 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit b0f6683 into narayan954:master Aug 3, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Dummygram
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛id text breaking on hover on profile card on hover card image css breake
2 participants
@biplavmz @narayan954