Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved search to navbar and displayed in a modal #1022

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

anamika7153
Copy link
Contributor

Closes: #882

Discription of changes

  • Moved search to navbar
  • Displayed search results in a modal
  • Ensured responsiveness
  • Added reset query in search input

Screenshots

image image
image image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you anamika7153! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 6fef9ed into narayan954:master Jul 28, 2023
4 of 5 checks passed
@anamika7153
Copy link
Contributor Author

@narayan954 you have not assigned level label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Search bar position
2 participants