Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update username regex #1039

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Update username regex #1039

merged 2 commits into from
Jul 30, 2023

Conversation

Palakkgoyal
Copy link
Contributor

This PR closes #1020
I have altered the regex to include only small case letter and also increased the length for username to 20. I also changed a method on signup page to check if the username exists or not.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit b28426e into narayan954:master Jul 30, 2023
4 of 5 checks passed
@Palakkgoyal Palakkgoyal deleted the username branch July 31, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Username must be small case
2 participants