-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shimmer effect on posts #1051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, but you said Shimmer effect on home and profile page for posts
in issue and it's for home page only. Please update that issue to only mention this.
No, I will add also on profile page. It somehow get slipped from my mind or I don't know there was some error. But, okay I will do changes for that too. |
it'a alright! |
This PR closes #1035
I have added shimmer effects on post of home page. While the post are loading the shimmer is shown and after being loaded the posts are shown.