Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shimmer effect on posts #1051

Merged
merged 6 commits into from
Jul 31, 2023
Merged

Conversation

Palakkgoyal
Copy link
Contributor

This PR closes #1035
I have added shimmer effects on post of home page. While the post are loading the shimmer is shown and after being loaded the posts are shown.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but you said Shimmer effect on home and profile page for posts in issue and it's for home page only. Please update that issue to only mention this.

@narayan954 narayan954 merged commit f184546 into narayan954:master Jul 31, 2023
4 of 5 checks passed
@Palakkgoyal
Copy link
Contributor Author

No, I will add also on profile page. It somehow get slipped from my mind or I don't know there was some error. But, okay I will do changes for that too.

@narayan954
Copy link
Owner

No, I will add also on profile page. It somehow get slipped from my mind or I don't know there was some error. But, okay I will do changes for that too.

it'a alright!

@Palakkgoyal Palakkgoyal deleted the shimmerEffect branch August 3, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shimmer effect on home and profile page for posts
2 participants