Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post delete cleanup #1059

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Conversation

Palakkgoyal
Copy link
Contributor

This PR closes #897
Add post delete cleanup. Made it such that all the images get deleted from the cloud. Post ref is deleted from user collection and then post is deleted from posts collection.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! by the way, can we use a db transaction here instead as a next step to this issue as you know, handling errors just won't be enough ?

@narayan954 narayan954 merged commit f59eea8 into narayan954:master Jul 31, 2023
3 of 4 checks passed
@Palakkgoyal
Copy link
Contributor Author

Thanks for introducing a new concept to me of DB transaction. Yes, I think it would be better and more reliable.

@Palakkgoyal Palakkgoyal deleted the postCleanup branch August 1, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post delete cleanup
2 participants