Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sounds effects for theme toggle feature ✨ #1067

Merged
merged 5 commits into from
Aug 1, 2023
Merged

feat: add sounds effects for theme toggle feature ✨ #1067

merged 5 commits into from
Aug 1, 2023

Conversation

0xabdulkhalid
Copy link
Contributor

Close #878

github-actions[bot]
github-actions bot reviewed Aug 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 0xabdulkhalid! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@0xabdulkhalid
Copy link
Contributor Author

0xabdulkhalid commented Aug 1, 2023 •
edited
Loading

@narayan954 your review is appreciated 🙌🏻

Can you add level2 for this ? I'm asking this because this PR comes under adding a new feature on existing code. Let me know your thoughts.

narayan954
narayan954 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954
Copy link
Owner

@narayan954 your review is appreciated 🙌🏻

Can you add level2 for this ? I'm asking this because this PR comes under adding a new feature on existing code. Let me know your thoughts.

fair enough! :)

@narayan954 narayan954 merged commit 32d602e into narayan954:master Aug 1, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
codepeak level2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: SOUND EFFECTS FOR THEME TOGGLE BUTTON 💡
2 participants
@0xabdulkhalid @narayan954