Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get dynamic notifcation sender data #1069

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

Palakkgoyal
Copy link
Contributor

@Palakkgoyal Palakkgoyal commented Aug 1, 2023

This PR closes #1061
I have added dynamic data for request sender. Now, the link also work which when clicked navigate to user profile.
Screenshot 2023-08-01 171746

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@narayan954
Copy link
Owner

Hi @Palakkgoyal can you please resolve the merge conflict?

narayan954

This comment was marked as duplicate.

@Palakkgoyal
Copy link
Contributor Author

Yes, sure

@Palakkgoyal Palakkgoyal closed this Aug 1, 2023
@Palakkgoyal Palakkgoyal force-pushed the notifData branch 2 times, most recently from ccf8e63 to d2a3820 Compare August 1, 2023 14:17
@Palakkgoyal Palakkgoyal reopened this Aug 1, 2023
@Palakkgoyal
Copy link
Contributor Author

I resolve the conflict. Can you please check.

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit b92ab96 into narayan954:master Aug 1, 2023
3 of 4 checks passed
@Palakkgoyal Palakkgoyal deleted the notifData branch August 3, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show user data on notification page
2 participants