Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Preview added #109

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Conversation

kshitij01042002
Copy link
Contributor

Added image preview feature before uploading a post. This works for single as well as multiple images
Please review the changes.
Issue : #106

image
image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@narayan954
Copy link
Owner

Hi @kshitij01042002 thanks for your contribution!
I have reviewed the changes and there's just 1 thing left to be done before merging. Please check that.
:)

@kshitij01042002
Copy link
Contributor Author

Don't merge this pr, I am raising a new PR which consists of three issues merge that one

@narayan954
Copy link
Owner

Don't merge this pr, I am raising a new PR which consists of three issues merge that one

wait, try having single pr per issue, it eases the maintainability as well as point distribution

@kshitij01042002
Copy link
Contributor Author

Should I close this pull request? Since the these changes are present in new pr as well.

@narayan954
Copy link
Owner

Should I close this pull request? Since the these changes are present in new pr as well.

even if I merge this pr, it won't create problem in the new pr. No need to close this :)

@narayan954 narayan954 merged commit dd010f8 into narayan954:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants