Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On click of view all comments, posts will also be visible along with … #117

Merged
merged 10 commits into from
Dec 12, 2022

Conversation

kshitij01042002
Copy link
Contributor

…option to comment too
image

@narayan954
Copy link
Owner

Please make the post and comments display side by side. For reference you can see the image below
image
left half covers the post and right half for the comments and option to add comment

@kshitij01042002
Copy link
Contributor Author

Okay!

@kshitij01042002
Copy link
Contributor Author

image

Will this work?

@narayan954
Copy link
Owner

narayan954 commented Dec 9, 2022

image

Will this work?

It looks good but comment adding feature should be below comment section only(and also smaller relative to post image), also please check for multiple images and long list of comments.

@kshitij01042002
Copy link
Contributor Author

For multiple images and and long list of comment I have to make scroll view component and then use it. It will be lot of work let's make this in another PR?
Till then can you merge this PR?

@narayan954
Copy link
Owner

For multiple images and and long list of comment I have to make scroll view component and then use it. It will be lot of work let's make this in another PR? Till then can you merge this PR?

We can't merge unfinished task, it could be troublesome later. I can increase the points for this PR to 20(hard) instead. Works?
Also, there're some merge conflicts.

@kshitij01042002
Copy link
Contributor Author

kshitij01042002 commented Dec 10, 2022

image
will this work?
Multuple images will be displayed same as it displays in the feed

@narayan954
Copy link
Owner

narayan954 commented Dec 10, 2022

yes, it'll work :) and rename that 'post' to 'comment' in the add to comment box

@narayan954 narayan954 marked this pull request as draft December 10, 2022 17:49
@narayan954
Copy link
Owner

When ready for review convert to pr :)

@kshitij01042002
Copy link
Contributor Author

Okay

@kshitij01042002 kshitij01042002 marked this pull request as ready for review December 10, 2022 18:47
@kshitij01042002
Copy link
Contributor Author

Things done in this PR

  • Show posts along with comments in view all comments
  • Posts and comments in Vertical grid
  • Created a reusable Scroll component
  • Long list of comments in scrollable format

@kshitij01042002
Copy link
Contributor Author

Done! You can merge this now

.env Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@narayan954 narayan954 merged commit a96eae7 into narayan954:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] <Displaying post with all the comments and also able to comment while seeing other comments>
2 participants