Add save post option on post page #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
narayan954
requested changes
Aug 7, 2023
There was a problem hiding this comment.
it looks great, but can you add the snackbar back as we're not indicating in any other way when the user saves a post. In any other social media, whenever we save posts we get a small indication, else we'd not be sure if post was saved, this affects a bit of UX, though it's not much good for Ui as you said.
|
But, we are providing user indication that post is saved by making the post save button green and unsaved when it appears like other. |
that's a valid argument ;-; , alright it's fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1166
I have added the save post option on post page and, I removed the snackbar that appears when we save post or remove it. Cause, I think its a very small task and we don't need to show it.
If you want snackbar back, I can add it again.