Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added Margin Property to resolved Gap between Buttons #1189

Merged
merged 3 commits into from
Aug 7, 2023
Merged

fix: Added Margin Property to resolved Gap between Buttons #1189

merged 3 commits into from
Aug 7, 2023

Conversation

NarendraKoya999
Copy link
Contributor

GSSOC'23 Contributor

Fixes Issue No #1137

Proposed Changes

  • Added Margin Right Property to Logout Button to Solved Gap Issues Between Logout and Cancel Buttons on Logout Dialogue Box.
  • I wrote Comment that Code Line.

github-actions[bot]
github-actions bot reviewed Aug 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you NarendraKoya999! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@NarendraKoya999
Copy link
Contributor Author

Hi @narayan954 . Please Review on this PR and add Valid Level Label under GSSOC'23. Thank You 😊

@narayan954 narayan954 linked an issue Aug 7, 2023 that may be closed by this pull request
[Bug]: Proper Gap is not Occurred in Logout Card like Logout and Cancel Buttons [Observe Screenshot] #1137
Closed
4 tasks
narayan954
narayan954 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 846a45d into narayan954:master Aug 7, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
codepeak level1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Proper Gap is not Occurred in Logout Card like Logout and Cancel Buttons [Observe Screenshot]
2 participants
@NarendraKoya999 @narayan954