Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a new look to sidebar #1193

Merged
merged 14 commits into from
Aug 10, 2023
Merged

Give a new look to sidebar #1193

merged 14 commits into from
Aug 10, 2023

Conversation

Palakkgoyal
Copy link
Contributor

This PR closes #1141
Updated the UI of sidebar and made it responsive.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Palakkgoyal , is this the expected behaviour of the sidebar??
image
it seems a bit off, like the circle around profile card,3 dots on top misaligned... Can you please take a look into that?

@Palakkgoyal
Copy link
Contributor Author

Hi @Palakkgoyal , is this the expected behaviour of the sidebar?? image it seems a bit off, like the circle around profile card,3 dots on top misaligned... Can you please take a look into that?

Its definitely not the desired behavior. I will remove that active state. And 3 dots misaligned? You mean that I should maintain a fix gap between those 3 dots and the other items?

@narayan954
Copy link
Owner

Hi @Palakkgoyal , is this the expected behaviour of the sidebar?? image it seems a bit off, like the circle around profile card,3 dots on top misaligned... Can you please take a look into that?

Its definitely not the desired behavior. I will remove that active state. And 3 dots misaligned? You mean that I should maintain a fix gap between those 3 dots and the other items?

alright, by misaligned I meant, there's a bigger left margin in other sidebar icons that those 3 dots, so they're not vertically aligned. Also, can we move that profile card to the top similar to this image, perhaps if it looks nice
image

@Palakkgoyal
Copy link
Contributor Author

Palakkgoyal commented Aug 8, 2023

Hey, I did some changes. Can you please check.
Screenshot 2023-08-08 193403

@narayan954
Copy link
Owner

Hey, I did some changes. Can you please check. Screenshot 2023-08-08 193403

sure, I am thinking to merge the refactoring pr first so there're very less merge conflicts

@narayan954
Copy link
Owner

Hi @Palakkgoyal , can you please fix these conflicts?

@Palakkgoyal
Copy link
Contributor Author

Yes, sure.

@Palakkgoyal Palakkgoyal reopened this Aug 8, 2023
@Palakkgoyal
Copy link
Contributor Author

I have solved the conflict. Can you please check.

@narayan954
Copy link
Owner

I have solved the conflict. Can you please check.

Hi @Palakkgoyal I just found this css conflicts with comment box css as well, can you please fix?
image

@Palakkgoyal
Copy link
Contributor Author

I have solved the conflict. Can you please check.

Hi @Palakkgoyal I just found this css conflicts with comment box css as well, can you please fix? image

Fixed

@narayan954
Copy link
Owner

I have solved the conflict. Can you please check.

Hi @Palakkgoyal I just found this css conflicts with comment box css as well, can you please fix? image

Fixed

when we click on view profile, some one else's profile opens... also, that box is overtaken by sidebar in terms of z index.
Also,profile picture is square now and the box opens very lower than expected. Can you check if you're facing these as well now? I think earlier I didn't face that.
image
image

@Palakkgoyal
Copy link
Contributor Author

I will fix others. But, I checked for this Aditya Roy's profile. I don't know why everytime we are getting there. I thought its happening with me only. I checked for user.uid and I think I checked for everything but still going to this profile. Even I am working on other PR. There also I am getting navigated(sometimes) to this one

@Palakkgoyal
Copy link
Contributor Author

Hey I checked just now that even on the deployed website we are reaching that profile only.

@Palakkgoyal
Copy link
Contributor Author

Hey hey. I get it there is problem with the way we are fetching data.
This function:
const docRef = db.collection("users", user?.uid);
const docSnap = await docRef.get();


You will think that this will return only one doc but, guess what it is returning an array of 87 docs(Perhaps all user docs). Let me check what is wrong.

@Palakkgoyal
Copy link
Contributor Author

Hey I fixed that in my centralize data PR. Check it out.
const docRef = doc(db, "users", user?.uid);
const docSnap = await getDoc(docRef);

@Palakkgoyal
Copy link
Contributor Author

Palakkgoyal commented Aug 10, 2023

Hey I have fixed the issues. The dropdown alignment issue was due to routing PR

@narayan954
Copy link
Owner

Hey hey. I get it there is problem with the way we are fetching data. This function: const docRef = db.collection("users", user?.uid); const docSnap = await docRef.get();

You will think that this will return only one doc but, guess what it is returning an array of 87 docs(Perhaps all user docs). Let me check what is wrong.

thanks a ton for finding that error!

@narayan954
Copy link
Owner

Hey I checked just now that even on the deployed website we are reaching that profile only.

I didn't check that, sorry

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954
Copy link
Owner

Thanks for your contribution @Palakkgoyal :)

@narayan954 narayan954 merged commit cbf062a into narayan954:master Aug 10, 2023
5 checks passed
@Palakkgoyal
Copy link
Contributor Author

Hey I checked just now that even on the deployed website we are reaching that profile only.

I didn't check that, sorry

No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI of sidebar
2 participants