-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give a new look to sidebar #1193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Palakkgoyal , is this the expected behaviour of the sidebar??
it seems a bit off, like the circle around profile card,3 dots on top misaligned... Can you please take a look into that?
Its definitely not the desired behavior. I will remove that active state. And 3 dots misaligned? You mean that I should maintain a fix gap between those 3 dots and the other items? |
alright, by misaligned I meant, there's a bigger left margin in other sidebar icons that those 3 dots, so they're not vertically aligned. Also, can we move that profile card to the top similar to this image, perhaps if it looks nice |
Hi @Palakkgoyal , can you please fix these conflicts? |
Yes, sure. |
I have solved the conflict. Can you please check. |
Hi @Palakkgoyal I just found this css conflicts with comment box css as well, can you please fix? |
Fixed |
when we click on view profile, some one else's profile opens... also, that box is overtaken by sidebar in terms of z index. |
I will fix others. But, I checked for this Aditya Roy's profile. I don't know why everytime we are getting there. I thought its happening with me only. I checked for user.uid and I think I checked for everything but still going to this profile. Even I am working on other PR. There also I am getting navigated(sometimes) to this one |
Hey I checked just now that even on the deployed website we are reaching that profile only. |
Hey hey. I get it there is problem with the way we are fetching data. You will think that this will return only one doc but, guess what it is returning an array of 87 docs(Perhaps all user docs). Let me check what is wrong. |
Hey I fixed that in my centralize data PR. Check it out. |
Hey I have fixed the issues. The dropdown alignment issue was due to routing PR |
thanks a ton for finding that error! |
I didn't check that, sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Thanks for your contribution @Palakkgoyal :) |
No worries. |
This PR closes #1141
Updated the UI of sidebar and made it responsive.