-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign Up Button Design Enhancement #1200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you iamRabia-N! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there iamRabia-N!, congratulations on your first pull request :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @iamRabia-N can you please check this issue?
Hi @narayan954 Output Screenshot |
thanks a lot! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with branch and code updation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @iamRabia-N still the css is breaking layout, as you can see
and
Can't we do something like, create a separate class for this margin-top and add this class only when user is anonymous?
Yeah, I am working on implementing this logic. |
also to give you more info, in suggestion component, we have variable currentUser and it has a method currentUser.isAnonymous, which tells if it's an anonymous user, use this logic to add the separate class to the component |
Hi @narayan954 |
Hi @iamRabia-N I checked and was able to solve it using that logic only, Do allow me to edit this pr and I'll push the fixes. |
around here @iamRabia-N you'll get the option to enable It's a good practise that you enable modifications by maintainer. |
@narayan954 You can edit this pull request now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! but do check the changes I made and learn what you did wrong?
This pull request contains the updated code for '[FEATURE] -Sign Up Button Design Enhancement'.
The issue related to this pull request is as follows:
[FEATURE] -Sign Up Button Design Enhancement #1171
Output Screenshot