Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Up Button Design Enhancement #1200

Merged
merged 14 commits into from
Aug 11, 2023
Merged

Sign Up Button Design Enhancement #1200

merged 14 commits into from
Aug 11, 2023

Conversation

iamRabia-N
Copy link
Contributor

This pull request contains the updated code for '[FEATURE] -Sign Up Button Design Enhancement'.
The issue related to this pull request is as follows:

[FEATURE] -Sign Up Button Design Enhancement #1171

Output Screenshot

ip (3)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you iamRabia-N! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there iamRabia-N!, congratulations on your first pull request :)

@narayan954 narayan954 linked an issue Aug 7, 2023 that may be closed by this pull request
4 tasks
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iamRabia-N can you please check this issue?
image

@iamRabia-N
Copy link
Contributor Author

Hi @narayan954
The bug is resolved in commit with id '2bae451299504e370ff83431dd775be27a560b8e'.

Output Screenshot

Screenshot (2679)

Screenshot (2678)

@narayan954
Copy link
Owner

Hi @narayan954 The bug is resolved in commit with id '2bae451299504e370ff83431dd775be27a560b8e'.

Output Screenshot

Screenshot (2679)

Screenshot (2678)

thanks a lot! :)

src/components/Suggestions/index.css Outdated Show resolved Hide resolved
Copy link
Contributor Author

@iamRabia-N iamRabia-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with branch and code updation

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iamRabia-N still the css is breaking layout, as you can see
image
and
image

Can't we do something like, create a separate class for this margin-top and add this class only when user is anonymous?

@iamRabia-N
Copy link
Contributor Author

Yeah, I am working on implementing this logic.

@narayan954
Copy link
Owner

Hi @iamRabia-N still the css is breaking layout, as you can see image and image

Can't we do something like, create a separate class for this margin-top and add this class only when user is anonymous?

also to give you more info, in suggestion component, we have variable currentUser and it has a method currentUser.isAnonymous, which tells if it's an anonymous user, use this logic to add the separate class to the component

@iamRabia-N
Copy link
Contributor Author

Hi @narayan954
I have tried the logic (we discussed yesterday) in jsx file . Its' not working.

@narayan954
Copy link
Owner

Hi @narayan954 I have tried the logic (we discussed yesterday) in jsx file . Its' not working.

Hi @iamRabia-N I checked and was able to solve it using that logic only, Do allow me to edit this pr and I'll push the fixes.
Also, there're some errors in routing that was causing another issue, I fixed those in those commits as well!

@narayan954
Copy link
Owner

around here @iamRabia-N you'll get the option to enable edits by maintainer option
image

It's a good practise that you enable modifications by maintainer.

@iamRabia-N
Copy link
Contributor Author

@narayan954 You can edit this pull request now.

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! but do check the changes I made and learn what you did wrong?

@narayan954 narayan954 merged commit 1da4d3b into narayan954:master Aug 11, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] -Sign Up Button Design Enhancement
2 participants