Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Center page added #1197 #1212

Merged
merged 13 commits into from
Aug 10, 2023
Merged

Conversation

biplavmz
Copy link
Contributor

@biplavmz biplavmz commented Aug 8, 2023

Faq Page added #1197
image

image

Hii @narayansoni I have added the help-Center page pls check and pls change the About us Image I Don't have Faq or HelpCenter Image pls change the Image as FAQ or HelpCenter

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you biplavmz! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@biplavmz
Copy link
Contributor Author

biplavmz commented Aug 9, 2023

hii @narayan954 can you pls check and merge my mr

@biplavmz biplavmz changed the title Faq page added #1208 Help Center page added #1208 Aug 9, 2023
@narayan954
Copy link
Owner

Faq Page added #1197 image

image Hii @narayansoni I have added the help-Center page pls check and pls change the About us Image I Don't have Faq or HelpCenter Image pls change the Image as FAQ or HelpCenter image

can you please add a slightly better accordion? and resolve conflicts?

@biplavmz biplavmz changed the title Help Center page added #1208 Help Center page added #1197 Aug 9, 2023
@biplavmz
Copy link
Contributor Author

biplavmz commented Aug 9, 2023

Hii @narayan954 i have resolve the issue and some changes pls check and merge my pr
image

image

@biplavmz
Copy link
Contributor Author

Hii @narayan954 can you please check and merge my pr

@narayan954
Copy link
Owner

Hii @narayan954 i have resolve the issue and some changes pls check and merge my pr

thanks I'm checking and merging right away!

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have you named the file notfound.jsx. It doesn't make sense

@narayan954
Copy link
Owner

If we're getting redirected to notfound.jsx, that doesn't mean we update the notfound page itself. Instead we find the source of problem that is, helpcenter page doesn't exist and we need to create one. You should have just followed the other footer pages in pages folder.

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to fix a whole lot of stuffs in this, thus reducing the level to 1

@narayan954 narayan954 linked an issue Aug 10, 2023 that may be closed by this pull request
4 tasks
@narayan954 narayan954 merged commit 57f7751 into narayan954:master Aug 10, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Want to Add Faq Section in help center page
2 participants