Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback vertical alignment #1219

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Conversation

Palakkgoyal
Copy link
Contributor

This PR closes #939
I fixed the alignment of feedback page and also setup the char limit for its inputs.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@narayan954
Copy link
Owner

also, can you disable the resize option for this textarea, so user can't alter as well?

@Palakkgoyal
Copy link
Contributor Author

Removed the marginTop as after merging the relativeRoutes PR there is no need to add margin. You can consider this issue for feedback charLimit.

@Palakkgoyal
Copy link
Contributor Author

also, can you disable the resize option for this textarea, so user can't alter as well?

Let me try

@Palakkgoyal
Copy link
Contributor Author

Done

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 95c3d53 into narayan954:master Aug 8, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feedback responsiveness
2 participants