-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post page UI #1224
Post page UI #1224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when we are commenting in the post page, username is set to someone named aditya Idk why. Can you please fix that?
Yes sure. I got the source of problem. |
Fixed. |
thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks awesome to me!
Hi @Palakkgoyal i noticed, you made prs/solved issues of other assignees without even asking/telling them. That's not a good practice. I told you to atleast leave a comment, so others know you're taking up their issues |
Sorry for that I thought they will not say anything as the issues were old. |
it's alright, we never know if they're working or not unless we ask. We can also inform them before taking their issue so either they can stop working or call us to stop |
Yes, you are right. I will not do that again :) |
This PR closes #806
![Screenshot 2023-08-09 202432](https://private-user-images.githubusercontent.com/116902573/259451983-55830f85-e6b3-4c38-bb08-ae52664635f2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2MjgzOTgsIm5iZiI6MTcyMDYyODA5OCwicGF0aCI6Ii8xMTY5MDI1NzMvMjU5NDUxOTgzLTU1ODMwZjg1LWU2YjMtNGMzOC1iYjA4LWFlNTI2NjQ2MzVmMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxMFQxNjE0NThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yZjQyZjRmMDVmODlmODc5Y2RlNjg3MWRjYzc4MDhjMTVhYzEyYzc5MjBmODc4MjEyNjg0NmFhYTczZDc1M2ZhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.yys_NxuU6urDYyzd23p7JdFj2H3BDTWrvqnMQsf6n8c)
![Screenshot 2023-08-09 202457](https://private-user-images.githubusercontent.com/116902573/259452043-7255bd15-3f65-4d62-b17b-7edc648fea99.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2MjgzOTgsIm5iZiI6MTcyMDYyODA5OCwicGF0aCI6Ii8xMTY5MDI1NzMvMjU5NDUyMDQzLTcyNTViZDE1LTNmNjUtNGQ2Mi1iMTdiLTdlZGM2NDhmZWE5OS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxMFQxNjE0NThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yNDJhYzA1Nzg5ZmMwOTVlY2U3NDkzOTFlMGFmYzA4NmNlN2MzYzU0ZDA5MjExNDFhMWE5NDQwZjAzZGJlZmY3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.yAXNlYo8WqwFGtJx8UXf5HSQtsGvdi0dM7ef5U7icBQ)
![Screenshot 2023-08-09 202721](https://private-user-images.githubusercontent.com/116902573/259452520-3071058b-31e2-4be2-98f5-5876e2ae0bb8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2MjgzOTgsIm5iZiI6MTcyMDYyODA5OCwicGF0aCI6Ii8xMTY5MDI1NzMvMjU5NDUyNTIwLTMwNzEwNThiLTMxZTItNGJlMi05OGY1LTU4NzZlMmFlMGJiOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxMFQxNjE0NThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04MDRiMDVlMmJlZWE5ZTdmYzdlYjZhZjM0YTBmYTM2ZTJiMGQ0NDcyYzJiZTc0NDI1ZjQxYTIzMGQ0NjJkNjkxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.YuYk4Ip9OKpHXdOrfvKNM1E9Gywv476GlH2GMaHvCxs)
I have given a new look to post page. Fixed console errors of post page. Refactored post page files and also deleted files that are not needed.