Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post page UI #1224

Merged
merged 8 commits into from
Aug 10, 2023
Merged

Post page UI #1224

merged 8 commits into from
Aug 10, 2023

Conversation

Palakkgoyal
Copy link
Contributor

@Palakkgoyal Palakkgoyal commented Aug 9, 2023

This PR closes #806
I have given a new look to post page. Fixed console errors of post page. Refactored post page files and also deleted files that are not needed.
Screenshot 2023-08-09 202432
Screenshot 2023-08-09 202457
Screenshot 2023-08-09 202721

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we are commenting in the post page, username is set to someone named aditya Idk why. Can you please fix that?

@Palakkgoyal
Copy link
Contributor Author

Yes sure. I got the source of problem.

@Palakkgoyal
Copy link
Contributor Author

Fixed.

@narayan954
Copy link
Owner

Fixed.

thanks!!

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome to me!

@narayan954 narayan954 merged commit 12fbc5a into narayan954:master Aug 10, 2023
4 of 5 checks passed
@narayan954
Copy link
Owner

narayan954 commented Aug 10, 2023

Hi @Palakkgoyal i noticed, you made prs/solved issues of other assignees without even asking/telling them. That's not a good practice. I told you to atleast leave a comment, so others know you're taking up their issues

@Palakkgoyal
Copy link
Contributor Author

Hi @Palakkgoyal i noticed, you made prs/solved issues of other assignees without even asking/telling them. That's not a good practice. I told you to atleast leave a comment, so others know you're taking up their issues

Sorry for that I thought they will not say anything as the issues were old.

@narayan954
Copy link
Owner

Hi @Palakkgoyal i noticed, you made prs/solved issues of other assignees without even asking/telling them. That's not a good practice. I told you to atleast leave a comment, so others know you're taking up their issues

Sorry for that I thought they will not say anything as the issues were old.

it's alright, we never know if they're working or not unless we ask. We can also inform them before taking their issue so either they can stop working or call us to stop

@Palakkgoyal
Copy link
Contributor Author

Hi @Palakkgoyal i noticed, you made prs/solved issues of other assignees without even asking/telling them. That's not a good practice. I told you to atleast leave a comment, so others know you're taking up their issues

Sorry for that I thought they will not say anything as the issues were old.

it's alright, we never know if they're working or not unless we ask. We can also inform them before taking their issue so either they can stop working or call us to stop

Yes, you are right. I will not do that again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Post Page UI
2 participants