footer added #1225
Merged
footer added #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@narayan954 done with PR please review it. |
narayan954
requested changes
Aug 11, 2023
There was a problem hiding this comment.
Hi @BhartiNagpure , footer component is quite confusing name, can you change it to a better name, like footerpagefooter or something better.
Also, due to some recent changes, there's a little need to update it.. can you please do it??
remove those extra icons on footer and hence make it small, one liner, with just those copyright and all lines you had added. Also, give it a background color with variable to make it compatible with theme
|
@narayan954 here is updated footer as you required changes please review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1209
Close #1209
In this PR I'm added footer into the footer pages.
