Fix login and signup page styling #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
narayan954
approved these changes
Aug 22, 2023
src/pages/Signup/index.jsx
Outdated
| @@ -298,9 +298,9 @@ const SignupScreen = () => { | |||
| handleSignInWithFacebook={(e) => | |||
| signInWithOAuth(e, enqueueSnackbar, navigate, false) | |||
| } | |||
| have_acct_question={"Already have an account?"} | |||
| have_acct_question={"Don't have an account?"} | |||
There was a problem hiding this comment.
I think perhaps this doesn't make sense, as we'd definitely want to sign in as an alternative in signup page. Also we'd want to navigate to signin from signup.
src/index.css
Outdated
| @@ -88,10 +88,11 @@ body { | |||
| } | |||
|
|
|||
| .navbar_wrapper { | |||
There was a problem hiding this comment.
this class is of no use now as we removed it, we should remove it from here as well
|
Thanks a lot for your contribution to dummygram! :) |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1003.
I have fixed the text color in the dark mode and is now visible. Also the margin issue has been fixed and sign up form styling is fixed and looks exactly like login form.