Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes singup page overflow issue #1269

Merged

Conversation

love-sonkar
Copy link
Contributor

fixes singup page profile picture is overflowing this is fixed in #1268

ggg

gga

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you love-sonkar! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@narayan954 narayan954 linked an issue Oct 5, 2023 that may be closed by this pull request
4 tasks
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

className is not in use, so this property wont even work. Needs fix.

src/pages/Signup/index.css Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@narayan954
Copy link
Owner

I've added a fix, kindly verify it on your local by pulling it.
LMK if it's okay now?

Copy link
Contributor Author

@love-sonkar love-sonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@narayan954 narayan954 merged commit d204587 into narayan954:master Oct 6, 2023
7 of 9 checks passed
@narayan954
Copy link
Owner

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] : In singup page profile picture is overflowing
2 participants