Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Icon Bug Fixed #1296

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Search Icon Bug Fixed #1296

merged 2 commits into from
Dec 9, 2023

Conversation

Mayank77maruti
Copy link
Contributor

when in mobile mode , we toggled from dark mode to light mode , the search button was having a bug that was fixed.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Mayank77maruti! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there Mayank77maruti!, congratulations on your first pull request :)

Copy link

sonarcloud bot commented Dec 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@narayan954
Copy link
Owner

when in mobile mode , we toggled from dark mode to light mode , the search button was having a bug that was fixed.

Hi @Mayank77maruti , do try to mention the issue number you've solved. That helps in closing that issue as completed.

@Mayank77maruti
Copy link
Contributor Author

I would make sure to put the issue number from the next time onwards.

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@narayan954 narayan954 merged commit 0e76690 into narayan954:master Dec 9, 2023
7 of 9 checks passed
@narayan954
Copy link
Owner

Thanks for your contribution! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants