Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Profile Page #1306

Merged
merged 5 commits into from
Dec 9, 2023
Merged

Fixed Profile Page #1306

merged 5 commits into from
Dec 9, 2023

Conversation

tushar-daiya
Copy link
Contributor

Fixes #1297
This issue was caused due to a change in character case of Friends to friends. The old accounts have an attribute Friends while the new one have friends with a small f. So when setting user data it was causing error to fetch newer accounts data.

Now the issue is fixed.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you tushar-daiya! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there tushar-daiya!, congratulations on your first pull request :)

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link

sonarcloud bot commented Dec 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@narayan954 narayan954 merged commit 0183e74 into narayan954:master Dec 9, 2023
6 of 8 checks passed
@narayan954
Copy link
Owner

Thanks for a spot on fix! Btw I just found, if we logout and login from different account, old account's data persists until we exit session or something. To confirm this, you can try to view your profile and you'd be redirected to the old login's username.

@tushar-daiya
Copy link
Contributor Author

Yes I am also facing the issue. Can i try fixing that?

@narayan954
Copy link
Owner

Yes I am also facing the issue. Can i try fixing that?

Sure, that'd be great! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when visiting someone's or my profile
2 participants