Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme file #186

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Update readme file #186

merged 5 commits into from
Feb 21, 2023

Conversation

Suryansh1720001
Copy link
Contributor

Hey @narayan954
This PR is raised under issue #183

Features that I added -

  • Project admin details
  • Add the contributing line with a guideline link so that everyone motivates by that.
  • Center heading for more attractive
  • adding the footer part in the readme file

Kindly check this and merge it accordingly.

github-actions[bot]
github-actions bot reviewed Feb 20, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

narayan954
narayan954 approved these changes Feb 21, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@narayan954 narayan954 merged commit 407b818 into narayan954:master Feb 21, 2023
@narayan954
Copy link
Owner

thanks for your contributions!

@narayan954 narayan954 linked an issue Feb 21, 2023 that may be closed by this pull request
[DOC] Readme file UPDATE #183
Closed
@Suryansh1720001
Copy link
Contributor Author

@narayan954
By mistake you forgot to add the medium label, I guess.
Kindly add that so that this repo consider under IWOC with some difficulty level.

@narayan954
Copy link
Owner

@narayan954 By mistake you forgot to add the medium label, I guess. Kindly add that so that this repo consider under IWOC with some difficulty level.

yeah sure, thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
medium
Projects
Dummygram
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Readme file UPDATE
2 participants
@Suryansh1720001 @narayan954