Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated new post modal #196

Merged
merged 7 commits into from
Feb 24, 2023
Merged

updated new post modal #196

merged 7 commits into from
Feb 24, 2023

Conversation

1010varun
Copy link
Contributor

Screenshot from 2023-02-22 15-22-39

@narayan954, I have implemented a new post modal and I would appreciate it if you could review my pull request and merge it.
I understand that you had previously mentioned creating a new branch for new issues, but I have already made these changes and cannot create a new branch at the moment. However, I will make sure to create a new branch for future issues.

Thank you.

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have marked some errors, please resolve them. Also, try to style the modal like picture you've provided.
new post modal

src/App.jsx Outdated Show resolved Hide resolved
src/App.jsx Outdated Show resolved Hide resolved
@1010varun
Copy link
Contributor Author

@narayan954,

I have made all the changes that you mentioned earlier.

Kindly review and merge my pr.

Thank You

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still, center tag exists, please fix it

@1010varun
Copy link
Contributor Author

@narayan954, I have removed all the center tags.

Kindly review and merge my pr.

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this workaround of center tag isn't responsive for other screens. You can check the mobile view for reference
mobile-view

using marginleft property won't make the elements centered and responsive here. You can use flexbox/grid to center the elements

@1010varun
Copy link
Contributor Author

1010varun commented Feb 24, 2023

image

image

@narayan954 is this perfect

@narayan954
Copy link
Owner

image

image

@narayan954 is this perfect

No, nothing is perfect, but in this case I'm suggesting you not to disturb the current alignment of other components as it looks in the screenshot below.
Screenshot_2023-02-24-23-38-42-066_com.android.chrome.jpg

@1010varun
Copy link
Contributor Author

image

@narayan954 now is this correct

@1010varun
Copy link
Contributor Author

@narayan954 now please review and merge my pr.

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 linked an issue Feb 24, 2023 that may be closed by this pull request
@narayan954 narayan954 merged commit fbd2230 into narayan954:master Feb 24, 2023
@narayan954
Copy link
Owner

thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[UI change] new post modal does not look good
2 participants