-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated new post modal #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made all the changes that you mentioned earlier. Kindly review and merge my pr. Thank You |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still, center tag exists, please fix it
@narayan954, I have removed all the center tags. Kindly review and merge my pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@narayan954 is this perfect |
No, nothing is perfect, but in this case I'm suggesting you not to disturb the current alignment of other components as it looks in the screenshot below. |
@narayan954 now is this correct |
@narayan954 now please review and merge my pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
thanks for your contribution |
@narayan954, I have implemented a new post modal and I would appreciate it if you could review my pull request and merge it.
I understand that you had previously mentioned creating a new branch for new issues, but I have already made these changes and cannot create a new branch at the moment. However, I will make sure to create a new branch for future issues.
Thank you.