Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #223

Merged
merged 12 commits into from
Mar 4, 2023
Merged

Update README.md #223

merged 12 commits into from
Mar 4, 2023

Conversation

Code1705
Copy link
Contributor

@Code1705 Code1705 commented Mar 2, 2023

please merge my PR under JWOC

narayan954
narayan954 requested changes Mar 2, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, looks like you've not fetched the latest changes, please fetch them and in that change, I already am covering a decent part of readme by a card. You can update that section to be not just about admin, but something like merge of about me and feedback /suggestions.My email and Linkedin if it needs to be mentioned.
Also, this pr doesn't solve the issues as you mentioned in your issue like "The new features to be added on point is missing and contribution guidelines could be made attractive and point wise" as you said.

@Code1705
Copy link
Contributor Author

Code1705 commented Mar 2, 2023

Ok definately I will work on it

@narayan954 narayan954 linked an issue Mar 2, 2023 that may be closed by this pull request
[DOCS] <description> #177
Closed
@Code1705
Copy link
Contributor Author

Code1705 commented Mar 3, 2023

as per your I have committed the changes, please could you merge my pr?

@narayan954
Copy link
Owner

as per your I have committed the changes, please could you merge my pr?

I'm traveling right now and will look into asap but before that please correct the spelling mistakes in latest commit

@Code1705
Copy link
Contributor Author

Code1705 commented Mar 3, 2023

Ok definately

@Code1705
Copy link
Contributor Author

Code1705 commented Mar 3, 2023 •
edited
Loading

done as per you said , now you can merge my PR

narayan954
narayan954 requested changes Mar 4, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, it looks good to me! except from the feedback section, where headings are at the center(inconsistent with other headings) and sentences are not properly aligned. Also div with center prop was not closed.
pr 223

@Code1705
Copy link
Contributor Author

Code1705 commented Mar 4, 2023

as per your instruction i made the required changes , you can merge it now.

@narayan954
Copy link
Owner

narayan954 commented Mar 4, 2023 •
edited
Loading

as per your instruction i made the required changes , you can merge it now.

you didn't follow the complete instruction when I told you to fetch the latest changes. this branch was 95 commits behind.Now these changes need more fix :( . Have a look now

@narayan954
Copy link
Owner

I will fix them now, but please you need to learn from this mistake.

narayan954
narayan954 approved these changes Mar 4, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@narayan954 narayan954 merged commit 25c794b into narayan954:master Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
medium
Projects
Dummygram
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] <description>
2 participants
@Code1705 @narayan954