Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme is updated with badges #328

Merged
merged 4 commits into from
May 24, 2023
Merged

Readme is updated with badges #328

merged 4 commits into from
May 24, 2023

Conversation

shraddha761
Copy link
Contributor

Issue reference - #312
Readme is successfully added with badges

github-actions[bot]
github-actions bot reviewed May 24, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

narayan954
narayan954 requested changes May 24, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the metrics to show correct information about our repo and if possible, can you please copy the updated changes to readme-hindi.md as well so they're in sync?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@narayan954 narayan954 linked an issue May 24, 2023 that may be closed by this pull request
Readme Update #312
Closed
narayan954
narayan954 reviewed May 24, 2023
View reviewed changes
README.md Show resolved Hide resolved
@narayan954
Copy link
Owner

ping/re request review when pr is ready

@shraddha761
Copy link
Contributor Author

ping/re request review when pr is ready
Ohh sorry I am beginner to open source

@narayan954
Copy link
Owner

narayan954 commented May 24, 2023 •
edited
Loading

ping/re request review when pr is ready
Ohh sorry I am beginner to open source

There's nothing to be sorry, I was just suggesting so I can review it quickly :)

@shraddha761
Copy link
Contributor Author

ping/re request review when pr is ready
Ohh sorry I am beginner to open source

There's nothing to be sorry, I was just suggesting so I can review it quickly :)

Okk Is their any changes in the PR

@narayan954
Copy link
Owner

ping/re request review when pr is ready
Ohh sorry I am beginner to open source

There's nothing to be sorry, I was just suggesting so I can review it quickly :)

Okk Is their any changes in the PR

I had one query I asked above in the review. Just resolve that and we're good

@shraddha761
Copy link
Contributor Author

ping/re request review when pr is ready
Ohh sorry I am beginner to open source

There's nothing to be sorry, I was just suggesting so I can review it quickly :)

Okk Is their any changes in the PR

I had one query I asked above in the review. Just resolve that and we're good

"uses-brains" more suits that's why I applied it

@narayan954
Copy link
Owner

ping/re request review when pr is ready
Ohh sorry I am beginner to open source

There's nothing to be sorry, I was just suggesting so I can review it quickly :)

Okk Is their any changes in the PR

I had one query I asked above in the review. Just resolve that and we're good

"uses-brains" more suits that's why I applied it

ohh okay, thank you!

narayan954
narayan954 approved these changes May 24, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit cb14f8e into narayan954:master May 24, 2023
3 checks passed
@narayan954
Copy link
Owner

thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
codepeak level1
Projects
Dummygram
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readme Update
2 participants
@shraddha761 @narayan954