Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#371 - Show no. of comments in the post #384

Merged
merged 1 commit into from
May 29, 2023
Merged

Issue#371 - Show no. of comments in the post #384

merged 1 commit into from
May 29, 2023

Conversation

VijayalakshmiGanesh
Copy link
Contributor

This PR contains the following changes:

  • instead of view all comments, show something like "view all 123 comments" or "view 1 comment" in case of comments.
  • in case without comment, "disable the button" and show something like "no comments yet".
  • in case without comment show something like "be the first one to comment" placeholder on input fields of comment.
  • Changed the font color of the disabled button to #616161 since the default font color was hard to see/read in disabled state

Screenshots:
image
image
image

github-actions[bot]
github-actions bot reviewed May 29, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

@VijayalakshmiGanesh VijayalakshmiGanesh mentioned this pull request May 29, 2023
Closed
@narayan954 narayan954 linked an issue May 29, 2023 that may be closed by this pull request
[FEATURE Enhancement] Show number of comments #371
Closed
narayan954

This comment was marked as resolved.

Sign in to view

@narayan954

This comment was marked as resolved.

Sign in to view
narayan954
narayan954 approved these changes May 29, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks perfect to me!

@narayan954 narayan954 merged commit ce9d409 into narayan954:master May 29, 2023
4 checks passed
@narayan954
Copy link
Owner

Thanks for your contribution!

@narayan954 narayan954 added level3 and removed level2 labels May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
codepeak level3
Projects
Dummygram
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE Enhancement] Show number of comments
2 participants
@VijayalakshmiGanesh @narayan954