-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve post UI/UX #506
Improve post UI/UX #506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes requested. Also, arrange the buttons in order of like,comment,share,save
@narayan954 Hey, I completed the changes can you please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes
why do you close it shubham, is there any problem you're facing? You know, you can just update this directly without closing. |
@narayan954 Hey, I made the following changes now you can check |
Ohh Actually I don't know that😥 |
It's alright, now you know! :) You just have to commit on your branch and this pr will be automatically updated |
Also, @SubhamB2003 follow proper github flow from next time, that is, create a separate branch from master for your feature, commit your changes there, and open a pull request from that branch. This ensures your master branch is clean and can be easily updated with my repo's master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First git pull and then git push, if you're facing error |
Okk thank you |
@narayan954 You can check now |
alright! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Also Thank you @narayan954 you tell me many things about GitHub workflow. |
Issue Solve: #504
Before
![image](https://private-user-images.githubusercontent.com/94003231/247178803-a9013f9f-a009-4015-b9cb-a2fb29ca2367.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI4MjU5NDksIm5iZiI6MTcyMjgyNTY0OSwicGF0aCI6Ii85NDAwMzIzMS8yNDcxNzg4MDMtYTkwMTNmOWYtYTAwOS00MDE1LWI5Y2ItYTJmYjI5Y2EyMzY3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODA1VDAyNDA0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTExZTMwYzcxODA1NDI4ZmFhYTdjMTRhY2E3NGY3MDVkYjRhOTU0YjQ3YWY4OWQwMDAyYWI0NjA5OTFkNzEzZGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.gc1yUdhlT_pXmNDwbBrSqtk4fd_Gowo8LGj9Rfo5aXU)
After
![image](https://private-user-images.githubusercontent.com/94003231/247178890-794b6317-fd58-4154-abd4-1079097ed0ba.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI4MjU5NDksIm5iZiI6MTcyMjgyNTY0OSwicGF0aCI6Ii85NDAwMzIzMS8yNDcxNzg4OTAtNzk0YjYzMTctZmQ1OC00MTU0LWFiZDQtMTA3OTA5N2VkMGJhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODA1VDAyNDA0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTczZmY2MzllM2IxNmE5YTViNWNiNGZmNGE2MTYwYTk3NGZiODkzODY3OWVjYTg2NzVjOTgwOTIzNjkwYzQ0YTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.tml-vCA156IQ6CeilakHOtSV3Ckk2Mfd4ICaLCo4Cu8)
Responsive
![image](https://private-user-images.githubusercontent.com/94003231/247179464-7f374083-cbad-475b-9437-ff6b6e664748.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI4MjU5NDksIm5iZiI6MTcyMjgyNTY0OSwicGF0aCI6Ii85NDAwMzIzMS8yNDcxNzk0NjQtN2YzNzQwODMtY2JhZC00NzViLTk0MzctZmY2YjZlNjY0NzQ4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODA1VDAyNDA0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNmZTI5NTQ3MDQyY2UwYmYyMDFhZDI2YmI4YjdkMzE4MGY1NzIyMGFmNjVmN2U3NDFhMzU4MTMzNWQ4YzY1YjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.-fZ6mv2fVIi3K6fZXNiQMvlqDrhGiWiYneOIK0M_dS8)
Hey, the ReadMore folder is not used. The new read more code is written at the bottom of the post.jsx