Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve post UI/UX #506

Merged
merged 12 commits into from
Jun 22, 2023
Merged

Improve post UI/UX #506

merged 12 commits into from
Jun 22, 2023

Conversation

SubhamB2003
Copy link
Contributor

Issue Solve: #504

Before
image

After
image

Responsive
image

Hey, the ReadMore folder is not used. The new read more code is written at the bottom of the post.jsx

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes requested. Also, arrange the buttons in order of like,comment,share,save

src/components/Flexbetween.jsx Outdated Show resolved Hide resolved
src/components/Post/index.jsx Outdated Show resolved Hide resolved
src/components/Post/index.jsx Outdated Show resolved Hide resolved
src/components/Post/index.jsx Outdated Show resolved Hide resolved
@SubhamB2003
Copy link
Contributor Author

changes requested. Also, arrange the buttons in order of like,comment,share,save

Hey, In the local system, I am not able to register or log in 😥Can you tell me why it's showing this
image

@narayan954
Copy link
Owner

changes requested. Also, arrange the buttons in order of like,comment,share,save

Hey, In the local system, I am not able to register or log in disappointed_relievedCan you tell me why it's showing this image

Hello, as I mentioned in discord, the feature is diabled for the prod environment. So you can login using google oauth or fb oauth for now

@SubhamB2003
Copy link
Contributor Author

changes requested. Also, arrange the buttons in order of like,comment,share,save

Hey, In the local system, I am not able to register or log in disappointed_relievedCan you tell me why it's showing this image

Hello, as I mentioned in discord, the feature is diabled for the prod environment. So you can login using google oauth or fb oauth for now

Oh okay

@SubhamB2003 SubhamB2003 reopened this Jun 21, 2023
@SubhamB2003
Copy link
Contributor Author

@narayan954 Hey, I completed the changes can you please check

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes

src/components/Flexbetween.jsx Outdated Show resolved Hide resolved
src/components/Post/index.jsx Outdated Show resolved Hide resolved
src/components/Post/index.jsx Outdated Show resolved Hide resolved
src/components/Post/index.jsx Outdated Show resolved Hide resolved
@SubhamB2003 SubhamB2003 reopened this Jun 22, 2023
@narayan954
Copy link
Owner

why do you close it shubham, is there any problem you're facing? You know, you can just update this directly without closing.

@SubhamB2003
Copy link
Contributor Author

@narayan954 Hey, I made the following changes now you can check

@SubhamB2003
Copy link
Contributor Author

Ohh Actually I don't know that😥

@narayan954
Copy link
Owner

Ohh Actually I don't know thatdisappointed_relieved

It's alright, now you know! :) You just have to commit on your branch and this pr will be automatically updated

@narayan954
Copy link
Owner

narayan954 commented Jun 22, 2023

Also, @SubhamB2003 follow proper github flow from next time, that is, create a separate branch from master for your feature, commit your changes there, and open a pull request from that branch. This ensures your master branch is clean and can be easily updated with my repo's master branch.
For next feature you can create new branch named as feature name.

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a bug, the captions are not showing up in posts... Can you fix that?
image

@narayan954
Copy link
Owner

First git pull and then git push, if you're facing error

@SubhamB2003
Copy link
Contributor Author

Also, @SubhamB2003 follow proper github flow from next time, that is, create a separate branch from master for your feature, commit your changes there, and open a pull request from that branch. This ensures your master branch is clean and can be easily updated with my repo's master branch. For next feature you can create new branch named as feature name.

Okk thank you

@SubhamB2003
Copy link
Contributor Author

@narayan954 You can check now
Actually, I forgot to add else condition in the caption that's why it's not showing

image

image

@narayan954
Copy link
Owner

@narayan954 You can check now Actually, I forgot to add else condition in the caption that's why it's not showing

image

image

alright!

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit b054fda into narayan954:master Jun 22, 2023
5 checks passed
@narayan954 narayan954 linked an issue Jun 22, 2023 that may be closed by this pull request
@SubhamB2003
Copy link
Contributor Author

looks good to me!

Also Thank you @narayan954 you tell me many things about GitHub workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] <UI Improvement>
2 participants