Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx Github action failing #54

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Conversation

KehindeBello
Copy link
Contributor

@KehindeBello KehindeBello commented Oct 2, 2022

Peer dependencies were causing the installation to fail and that has been addressed.

The ERR_REQUIRE_ESM error in greeting got a temporary solution till an official one is available.Link

I do not have a firebase service account to test the deployment :(
but I'm confident it'll go through 馃憤

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me , let's check by merging

@narayan954 narayan954 merged commit 64e9582 into narayan954:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants