-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added feature of forgot password #568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)
@narayan954 added the forgot password feature please review it and suggest the changes if any. |
Hello @rudrakushwaha , did you check/test how it looks? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we installing a whole library just to get a toast component, whose alternative "snackbar" is already present/installed and in use in the same component. Please correct this and use snackbar if there's no actual need for toast component.
is this done? |
Please give me some more time. |
it's alright take your time |
hello sir @narayan954 I have fixed the CSS and commited the changes. I have pushed it into the master branch but it is not displaying any new commit. And when I push it to addfeature branch I get this error.Please help failed to push some refs to 'https://github.com/rudrakushwaha/dummygram.git' |
@narayan954 earliar addfeature branch is 21 commits behind now I have fetching and merging it is 5 commits ahead. |
Hi @rudrakushwaha , if you read the error, you'll find it says "Updates were rejected because the remote contains work that you do not have locally. This is usually caused by another repository pushing to the same ref. You may want to first integrate the remote changes (e.g., 'git pull ...') before pushing again. " In simple words, someone has pushed some changes as well to the branch you're trying to push on. So you'll first need to git pull, then git push. Git pull command is used here to update your branch with the remote. So please run git pull first and update your branch with remote. Also, to give your more hint, I had pushed a fix commit to your repository, so remote branch of yours runs ahead of your local branch and you'll need to update it with remote before making changes |
it's alright, these 5 commits are your own commits, that you wish to add in my repo by creating this pull request. Here in this pull request you can see these 5 commits in the commits section as well(look above in the head of your pull request). I hope this helps. |
Done sir @narayan954 Thank you so much. I have fixed the home page CSS you can check it and I have used toast feature of chakra UI as I am new to snackbar so I will have to go through it. |
snackbar is not much different, and it's already implemented, you just need to import and use there.... in fact it's present in that file as well, just copy the implementation |
okay @narayan954 |
@narayan954 done. Now please check it I have removed the chakraUI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Thank you sir @narayan954 |
No description provided.