Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI for comment section #573

Merged
merged 31 commits into from
Jun 30, 2023
Merged

Conversation

SubhamB2003
Copy link
Contributor

Issue Solved: #508

@narayan954
Copy link
Owner

Also, don't completely remove the earlier modal. Let it stay and instead of using it for view all comments, use that on single clicking the post picture/text

@SubhamB2003
Copy link
Contributor Author

SubhamB2003 commented Jun 26, 2023

Also, don't completely remove the earlier modal. Let it stay and instead of using it for view all comments, use that on single clicking the post picture/text

Hey, Can you tell me to add this comment UI only for a single post-view page?
In this page only
image

@narayan954
Copy link
Owner

ll me to add this comment UI only for a single post-view page?
In this page only

No Im saying shift the early view functionality to click on post rather than view all comments. Let both exist. On clicking view all comments, you feature shows up and when single clicking the post, old view comes up

@SubhamB2003
Copy link
Contributor Author

@narayan954 Is it ok?

dummaygram3.mp4

@narayan954
Copy link
Owner

@narayan954 Is it ok?

dummaygram3.mp4

yes it is! have you commited this? so I can quickly review and merge

@SubhamB2003
Copy link
Contributor Author

@narayan954 Is it ok?
dummaygram3.mp4

yes it is! have you commited this? so I can quickly review and merge

Wait I commit now.

@narayan954
Copy link
Owner

@narayan954 Is it ok?
dummaygram3.mp4

yes it is! have you commited this? so I can quickly review and merge

Wait I commit now.

you haven't commited yet ...

@SubhamB2003
Copy link
Contributor Author

SubhamB2003 commented Jun 30, 2023

@narayan954 You can check now. I also fixed the 404 error page issue.

@narayan954
Copy link
Owner

@narayan954 You can check now. I also fixed the 404 error page issue.

alright, on it! :)

@narayan954
Copy link
Owner

@narayan954 Is it ok?

dummaygram3.mp4

you didn't push this?? old post view?
Also, comment section words are not checked for breaking
image

@narayan954
Copy link
Owner

@narayan954 Is it ok?
dummaygram3.mp4

you didn't push this?? old post view? Also, comment section words are not checked for breaking image

it's alright if you didn't do this, I'll update

@SubhamB2003
Copy link
Contributor Author

Yeah, I checked all of this it's working fine I only changed the single post view comment section because someone is already updated it.

@narayan954 narayan954 linked an issue Jun 30, 2023 that may be closed by this pull request
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 045834c into narayan954:master Jun 30, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] <Change the All comments show modal>
2 participants