-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New UI for comment section #573
Conversation
Also, don't completely remove the earlier modal. Let it stay and instead of using it for view all comments, use that on single clicking the post picture/text |
No Im saying shift the early view functionality to click on post rather than view all comments. Let both exist. On clicking view all comments, you feature shows up and when single clicking the post, old view comes up |
@narayan954 Is it ok? dummaygram3.mp4 |
yes it is! have you commited this? so I can quickly review and merge |
Wait I commit now. |
you haven't commited yet ... |
@narayan954 You can check now. I also fixed the 404 error page issue. |
alright, on it! :) |
you didn't push this?? old post view? |
it's alright if you didn't do this, I'll update |
Yeah, I checked all of this it's working fine I only changed the single post view comment section because someone is already updated it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Issue Solved: #508