Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searchfile added #577

Merged
merged 14 commits into from
Jul 3, 2023
Merged

Searchfile added #577

merged 14 commits into from
Jul 3, 2023

Conversation

BhartiNagpure
Copy link
Contributor

@BhartiNagpure BhartiNagpure commented Jun 26, 2023 •
edited
Loading

Search bar added

close #510

github-actions[bot]
github-actions bot reviewed Jun 26, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

narayan954
narayan954 requested changes Jun 26, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested changes

src/components/SearchBar/index.jsx Outdated Show resolved Hide resolved
src/components/SearchBar/index.jsx Outdated Show resolved Hide resolved
@narayan954
Copy link
Owner

are you working on this?

@BhartiNagpure
Copy link
Contributor Author

Yes, I will create PR till tomorrow morning please give me time.

@narayan954
Copy link
Owner

Yes, I will create PR till tomorrow morning please give me time.

Oh it's alright, just wanted to confirm! :)

@BhartiNagpure
Copy link
Contributor Author

BhartiNagpure commented Jun 30, 2023 •
edited
Loading

are you working on this
@narayan954 I have done my work please go through it.

@narayan954
Copy link
Owner

are you working on this
@narayan954 I have done my work please go through it.

Okay sure :)

narayan954
narayan954 requested changes Jun 30, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

today I'll check the alternatives as to using something like full text search.You may try researching as well, please

src/components/SearchBar/index.jsx Outdated Show resolved Hide resolved
@BhartiNagpure
Copy link
Contributor Author

today I'll check the alternatives as to using something like full text search.You may try researching as well, please

Ok

@narayan954
Copy link
Owner

narayan954 commented Jul 1, 2023 •
edited
Loading

Hi @BhartiNagpure check these stack overflow answers:
answer1
answer2
so you can fix the query.

Read them, and implement the free solution

@BhartiNagpure
Copy link
Contributor Author

Hi @BhartiNagpure check these stack overflow answers: answer1 answer2 so you can fix the query.

Read them, and implement the free solution

Thanks alot

@BhartiNagpure
Copy link
Contributor Author

Hi @BhartiNagpure check these stack overflow answers: answer1 answer2 so you can fix the query.
Read them, and implement the free solution

Thanks alot

Hi @BhartiNagpure check these stack overflow answers: answer1 answer2 so you can fix the query.

Read them, and implement the free solution

@narayan954 you can check now I am fetching data after writing searchtext from the firebase.

@narayan954
Copy link
Owner

Hi @BhartiNagpure check these stack overflow answers: answer1 answer2 so you can fix the query.
Read them, and implement the free solution

Thanks alot

Hi @BhartiNagpure check these stack overflow answers: answer1 answer2 so you can fix the query.
Read them, and implement the free solution

@narayan954 you can check now I am fetching data after writing searchtext from the firebase.

alright!

BhartiNagpure
BhartiNagpure commented Jul 3, 2023
View reviewed changes
Copy link
Contributor Author

@BhartiNagpure BhartiNagpure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review all changes

@narayan954
Copy link
Owner

review all changes

yeah sure, on it 🫡

narayan954
narayan954 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 5136dd8 into narayan954:master Jul 3, 2023
4 of 6 checks passed
@narayan954
Copy link
Owner

Thanks for your contribution! :)

@BhartiNagpure
Copy link
Contributor Author

Thanks for your contribution! :)

Its my pleasure 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
codepeak level3
Projects
Dummygram
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] < Search Bar
2 participants
@BhartiNagpure @narayan954