-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create about page for dummygram #603
Conversation
Hi Palak, sorry I didn't read your comment and implemented it myself. I just read it. You may look at this answer on stackoverflow for the brief description. and the code commits to see the implementation if you wish to understand. |
I think you might be getting 30 instead of 28 as that's the pagination limit of github api for list of commits. I took help of a brilliant solution, give it a read as I mentioned the source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
I checked the solution and I think I get confused due to regex part as I have not used or made any regex by myself. Thanks for sharing. |
It's alright. |
another pr I missed the label I guess |
Hey please take care of labels. From onwards I will remind you for my PRs🤦♀️😂. |
hehe sure XD |
This PR closes issue no. #552
I have dynamically added data of number of forks and stars but unable to do the same for number of commits. When I tried to fetch total commits, it only gave me 28 rather than all. I tried some solutions but according to me there is a need of access token by the owner.