Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create about page for dummygram #603

Merged
merged 5 commits into from
Jul 1, 2023

Conversation

Palakkgoyal
Copy link
Contributor

This PR closes issue no. #552
I have dynamically added data of number of forks and stars but unable to do the same for number of commits. When I tried to fetch total commits, it only gave me 28 rather than all. I tried some solutions but according to me there is a need of access token by the owner.

@narayan954
Copy link
Owner

This PR closes issue no. #552 I have dynamically added data of number of forks and stars but unable to do the same for number of commits. When I tried to fetch total commits, it only gave me 28 rather than all. I tried some solutions but according to me there is a need of access token by the owner.

Hi Palak, sorry I didn't read your comment and implemented it myself. I just read it.

You may look at this answer on stackoverflow for the brief description. and the code commits to see the implementation if you wish to understand.

@narayan954
Copy link
Owner

This PR closes issue no. #552 I have dynamically added data of number of forks and stars but unable to do the same for number of commits. When I tried to fetch total commits, it only gave me 28 rather than all. I tried some solutions but according to me there is a need of access token by the owner.

I think you might be getting 30 instead of 28 as that's the pagination limit of github api for list of commits. I took help of a brilliant solution, give it a read as I mentioned the source.

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit e2d9b4b into narayan954:master Jul 1, 2023
5 of 7 checks passed
@Palakkgoyal
Copy link
Contributor Author

I checked the solution and I think I get confused due to regex part as I have not used or made any regex by myself. Thanks for sharing.

@Palakkgoyal Palakkgoyal deleted the createAboutPage branch July 2, 2023 09:08
@narayan954
Copy link
Owner

I checked the solution and I think I get confused due to regex part as I have not used or made any regex by myself. Thanks for sharing.

It's alright.

@narayan954
Copy link
Owner

another pr I missed the label I guess

@Palakkgoyal
Copy link
Contributor Author

Hey please take care of labels. From onwards I will remind you for my PRs🤦‍♀️😂.

@narayan954
Copy link
Owner

Hey please take care of labels. From onwards I will remind you for my PRswoman_facepalmingjoy.

hehe sure XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants