Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1)modified user Schema to have subcollections, 2)added friend request… #613

Merged
merged 16 commits into from
Jul 3, 2023

Conversation

gitpugal
Copy link
Contributor

@gitpugal gitpugal commented Jul 1, 2023

… toggling and 3)adjusted the visibility of darkmode button on mobile screens

… toggling and 3)adjusted the visibility of darkmode button on mobile screens
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

@narayan954
Copy link
Owner

I'll be reviewing tomorrow, you should remove your credentials from the commit.

@gitpugal
Copy link
Contributor Author

gitpugal commented Jul 2, 2023

Yeah that's fine you can review and inform me then I'll change the credentials.

@gitpugal
Copy link
Contributor Author

gitpugal commented Jul 2, 2023

can we merge now is it ok now?

@narayan954
Copy link
Owner

can we merge now is it ok now?

checking now

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes requested , I'll test it again

src/components/ImgUpload/index.jsx Outdated Show resolved Hide resolved
src/lib/firebase.js Outdated Show resolved Hide resolved
src/pages/Profile/index.jsx Show resolved Hide resolved
src/pages/Signup/index.jsx Outdated Show resolved Hide resolved
src/pages/Signup/index.jsx Show resolved Hide resolved
src/pages/Signup/index.jsx Show resolved Hide resolved
@narayan954
Copy link
Owner

… toggling and 3)adjusted the visibility of darkmode button on mobile screens

I'll be converting this pr to level 3 if it's okay? as you've solved multiple issues

@narayan954 narayan954 linked an issue Jul 2, 2023 that may be closed by this pull request
@gitpugal
Copy link
Contributor Author

gitpugal commented Jul 2, 2023

yeah that'd be fine!.

@gitpugal
Copy link
Contributor Author

gitpugal commented Jul 2, 2023

@narayan954 Can you please now check the requested changes, I've resolved them as you've mentioned.

@narayan954
Copy link
Owner

@narayan954 Can you please now check the requested changes, I've resolved them as you've mentioned.

sure, i'll check today

@gitpugal
Copy link
Contributor Author

gitpugal commented Jul 3, 2023

Good afternoon @narayan954 , Can I know the status of the PR 613 and if any changes needed from my side.

@narayan954
Copy link
Owner

Good afternoon @narayan954 , Can I know the status of the PR 613 and if any changes needed from my side.

hi @gitpugal greetings
actually on signup using oauth, user is not created in the user collection... I'm looking into it

@narayan954
Copy link
Owner

Good afternoon @narayan954 , Can I know the status of the PR 613 and if any changes needed from my side.

hi @gitpugal greetings actually on signup using oauth, user is not created in the user collection... I'm looking into it

it's working,merging this

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit c794e75 into narayan954:master Jul 3, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Creating users collections.
2 participants