-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1)modified user Schema to have subcollections, 2)added friend request… #613
Conversation
… toggling and 3)adjusted the visibility of darkmode button on mobile screens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)
I'll be reviewing tomorrow, you should remove your credentials from the commit. |
Yeah that's fine you can review and inform me then I'll change the credentials. |
can we merge now is it ok now? |
checking now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes requested , I'll test it again
I'll be converting this pr to level 3 if it's okay? as you've solved multiple issues |
yeah that'd be fine!. |
@narayan954 Can you please now check the requested changes, I've resolved them as you've mentioned. |
sure, i'll check today |
Good afternoon @narayan954 , Can I know the status of the PR 613 and if any changes needed from my side. |
hi @gitpugal greetings |
it's working,merging this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
… toggling and 3)adjusted the visibility of darkmode button on mobile screens