Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the login page #624

Merged
merged 9 commits into from
Jul 4, 2023
Merged

Improve the login page #624

merged 9 commits into from
Jul 4, 2023

Conversation

Walexz01
Copy link
Contributor

@Walexz01 Walexz01 commented Jul 3, 2023

Description

remove the nav from the login and signup page.
create a responsive login page

Solves the issue #623

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshot_20230703_045808

localhost_3000_dummygram_login

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

@narayan954
Copy link
Owner

Hi, I'm reviewing in chronological order :) allow me some time

@narayan954 narayan954 linked an issue Jul 3, 2023 that may be closed by this pull request
@narayan954
Copy link
Owner

Hi @Walexz01 it's looking really cool!
But it's perhaps too big for the screen even at 100 percent scale as you can see in the images below of edge and firefox
microsoft edge
firefox

Can you please use heights as viewport heights so we don't have to scroll.
Also, in mobile screens, some part is beyond screen to the right as you can see.
image
Thank you!

@Walexz01
Copy link
Contributor Author

Walexz01 commented Jul 3, 2023

Ok sir will do that

@narayan954
Copy link
Owner

Ok sir will do that

You did a great job! Also, don't forget to git pull the changes I've made on your repo

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit e697778 into narayan954:master Jul 4, 2023
4 of 6 checks passed
@narayan954
Copy link
Owner

Thanks for your contribution @Walexz01 :)

@Walexz01
Copy link
Contributor Author

Walexz01 commented Jul 4, 2023

Thanks @narayan954
Really Happy to contribute sir ❤️

@narayan954 narayan954 added level3 and removed level2 labels Jul 4, 2023
@Walexz01 Walexz01 deleted the auhpage branch July 5, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Improve the login page
2 participants