Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New logo Added #631

Merged
merged 11 commits into from
Jul 4, 2023
Merged

New logo Added #631

merged 11 commits into from
Jul 4, 2023

Conversation

Tisha6661
Copy link
Contributor

@Tisha6661 Tisha6661 commented Jul 3, 2023

Added the new logo for the website and made changes to the desired pages to fit it. The colors match the other elements on the navbar.

Issue Number- #608

WhatsApp Image 2023-07-03 at 15 17 32

Added the new logo for the website, and made changes changes to the desired pages to fi t it.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

@narayan954
Copy link
Owner

narayan954 commented Jul 3, 2023

Hi @Tisha6661 ,this logo looks really great! ... and I was thinking, should we remove the background colour from logo or is it better that way?? If it looks right to you as a user , then it's fine... Also, have you checked dark mode as well?
I'm reviewing pull requests in chronological order :) allow me some time to review this.

@Tisha6661
Copy link
Contributor Author

Tisha6661 commented Jul 3, 2023

Yes I tried it without background and some colours, here-
image

But at the end the logo's background goes with the other buttons on navbar, so it looks more nice. Also, i checked it on dark mode, it goes well there.

@Tisha6661
Copy link
Contributor Author

Also i feel that the Ui of the horizontal navbar could be made better, to go with the changes of the logo, should i generate that issue?

@narayan954
Copy link
Owner

Yes I tried it without background and some colours, here- image

But at the end the logo's background goes with the other buttons on navbar, so it looks more nice. Also, i checked it on dark mode, it goes well there.

Hi @Tisha6661 , I was checking it, and it doesn't go well with the readme in terms of fit, can you please check that and fix?

@narayan954
Copy link
Owner

Also, in about section, it's not checked for size
image

@narayan954
Copy link
Owner

Also, in about section, it's not checked for size image

do git pull before making any changes so you dont get into a conflict

@narayan954 narayan954 linked an issue Jul 3, 2023 that may be closed by this pull request
@narayan954
Copy link
Owner

Also i feel that the Ui of the horizontal navbar could be made better, to go with the changes of the logo, should i generate that issue?

Yes, sure, also, we can remove the favourites and profile option from there.... Also for your information, there'd be settings option there as well in the drop down.

Tisha6661 and others added 4 commits July 4, 2023 11:59
Logo is updated everywhere
logo updated
Updated logo on about page
@Tisha6661
Copy link
Contributor Author

@narayan954 I have done all the changes-

image
image
image
image
image
image

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954
Copy link
Owner

Thanks for your contribution! :)

@narayan954 narayan954 merged commit 32fc808 into narayan954:master Jul 4, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

New logo for the website
2 participants