Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting page with sound settings #635

Merged
merged 7 commits into from
Jul 4, 2023
Merged

Setting page with sound settings #635

merged 7 commits into from
Jul 4, 2023

Conversation

Palakkgoyal
Copy link
Contributor

This PR closes issue no. #620
Screenshot 2023-07-03 232811

narayan954
narayan954 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 linked an issue Jul 4, 2023 that may be closed by this pull request
[FEATURE] Create a settings page #620
Closed
@narayan954 narayan954 merged commit fa3d4cc into narayan954:master Jul 4, 2023
5 of 7 checks passed
@narayan954
Copy link
Owner

is level 2 label ok or level 3, what do you think??

@Palakkgoyal
Copy link
Contributor Author

I think it should be level3 cause it take more than I thought. In this I have created a UI, setup routes, make a centralized system for turning off sounds which can be further useful in turning off a particular sound, finding content to write and make it responsive(not completely but, sufficient for now).
If it is ok from your side to give level3 then, I think we should go for it.

@Palakkgoyal Palakkgoyal deleted the settingPage branch July 5, 2023 02:31
@narayan954 narayan954 mentioned this pull request Jul 5, 2023
Closed
@narayan954
Copy link
Owner

narayan954 commented Jul 5, 2023 •
edited
Loading

I think it should be level3 cause it take more than I thought. In this I have created a UI, setup routes, make a centralized system for turning off sounds which can be further useful in turning off a particular sound, finding content to write and make it responsive(not completely but, sufficient for now). If it is ok from your side to give level3 then, I think we should go for it.

correct! I thought so :P It's a completely new feature

@narayan954 narayan954 added level3 and removed level2 labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
codepeak level3
Projects
Dummygram
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create a settings page
2 participants
@Palakkgoyal @narayan954